Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

report: use ru_stime for system CPU calculation #26286

Merged
merged 1 commit into from
Feb 27, 2019
Merged

report: use ru_stime for system CPU calculation #26286

merged 1 commit into from
Feb 27, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Feb 24, 2019

Prior to this change, user and system CPU were the same values.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@cjihrig sadly an error occured when I tried to trigger a build :(

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Feb 24, 2019
@richardlau richardlau added the report Issues and PRs related to process.report. label Feb 24, 2019
@cjihrig
report: use ru_stime for system CPU calculation
4255190 
PR-URL: nodejs#26286
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@cjihrig
Copy link
Contributor Author

cjihrig commented Feb 27, 2019

Green CI: https://ci.nodejs.org/job/node-test-pull-request/21012/

@cjihrig cjihrig merged commit 4255190 into nodejs:master Feb 27, 2019
@cjihrig cjihrig deleted the report-cpu branch February 27, 2019 00:59
addaleax pushed a commit that referenced this pull request Mar 1, 2019
@cjihrig @addaleax
report: use ru_stime for system CPU calculation
ba5f31a 
PR-URL: #26286
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 4, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@targos targos targos approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. report Issues and PRs related to process.report.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @nodejs-github-bot @jasnell @addaleax @lpinca @targos @richardlau