Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: hello addon example should return "world" #26328

Closed
wants to merge 1 commit into from
Closed

doc: hello addon example should return "world" #26328

wants to merge 1 commit into from

Conversation

geirha
Copy link
Contributor

@geirha geirha commented Feb 26, 2019

The N-API version of the hello example, returned "hello" instead of "world".

Checklist

@nodejs-github-bot nodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Feb 26, 2019
@geirha
doc: hello addon example should return "world"
6ff96a3 
The N-API version of the hello example, returned "hello" instead of "world".
@geirha geirha marked this pull request as ready for review February 26, 2019 21:43
@lpinca
Copy link
Member

lpinca commented Mar 4, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2754/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2019
mhdawson
mhdawson approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 5, 2019
@geirha @BridgeAR
doc: hello addon example should return "world"
9a2025c 
The N-API version of the hello example, returned "hello" instead of
"world".

PR-URL: nodejs#26328
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@BridgeAR
Copy link
Member

BridgeAR commented Mar 5, 2019

Landed in 9a2025c 🎉

@BridgeAR BridgeAR closed this Mar 5, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@geirha @BridgeAR
doc: hello addon example should return "world"
d2e9e52 
The N-API version of the hello example, returned "hello" instead of
"world".

PR-URL: nodejs#26328
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@geirha @BethGriggs
doc: hello addon example should return "world"
a562aba 
The N-API version of the hello example, returned "hello" instead of
"world".

PR-URL: #26328
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anto Aravinth <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@lpinca lpinca lpinca approved these changes

@antsmartian antsmartian antsmartian approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@geirha @lpinca @BridgeAR @jasnell @antsmartian @mhdawson @nodejs-github-bot