src: fix build when NODE_USE_V8_PLATFORM is not defined #26380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
addaleax
approved these changes
Mar 1, 2019
nitsakh
added a commit
to electron/node
that referenced
this pull request
Mar 1, 2019
This should go away once we are on the next node version which has this PR merged in nodejs/node#26380
cjihrig
approved these changes
Mar 3, 2019
jasnell
approved these changes
Mar 4, 2019
BridgeAR
approved these changes
Mar 6, 2019
BridgeAR
added
the
author ready
refack
approved these changes
Mar 6, 2019
PR-URL: nodejs#26380 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
PR-URL: nodejs#26380 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
PR-URL: #26380 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
codebytere
pushed a commit
to electron/node
that referenced
this pull request
Mar 20, 2019
This should go away once we are on the next node version which has this PR merged in nodejs/node#26380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trace_enabled_categoriesis not defined, so the build fails whenNODE_USE_V8_PLATFORMis false.This change fixes that with the appropriate value.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes