Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: clarify http.Agent constructor options #26412

Closed
wants to merge 1 commit into from
Closed

doc: clarify http.Agent constructor options #26412

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Mar 3, 2019

Fixes: #26357

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot
Copy link
Collaborator

@lpinca build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2748/pipeline

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Mar 3, 2019
shisama
shisama reviewed Mar 3, 2019
View reviewed changes
doc/api/http.md Outdated Show resolved Hide resolved
@BridgeAR BridgeAR requested a review from mcollina March 3, 2019 22:58
Trott
Trott reviewed Mar 4, 2019
View reviewed changes
doc/api/http.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Mar 4, 2019
View reviewed changes
doc/api/http.md Outdated Show resolved Hide resolved
mcollina
mcollina approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR
Copy link
Member

BridgeAR commented Mar 5, 2019

Lite-CI https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/2762/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 5, 2019
@BridgeAR
Copy link
Member

BridgeAR commented Mar 5, 2019

Landed in 8a291a8 🎉

@BridgeAR BridgeAR closed this Mar 5, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 5, 2019
@lpinca @BridgeAR
doc: clarify http.Agent constructor options
8a291a8 
PR-URL: nodejs#26412
Fixes: nodejs#26357
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@lpinca lpinca deleted the gh-26357 branch March 6, 2019 06:36
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
@lpinca @BridgeAR
doc: clarify http.Agent constructor options
8b8297d 
PR-URL: nodejs#26412
Fixes: nodejs#26357
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Mar 13, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@lpinca @BethGriggs
doc: clarify http.Agent constructor options
aa49bf5 
PR-URL: #26412
Fixes: #26357
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@shisama shisama shisama approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Agent Keep-Alive behavior
7 participants
@lpinca @nodejs-github-bot @BridgeAR @mcollina @jasnell @Trott @shisama