-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto: simplify GetPublicOrPrivateKeyFromJs #26454
Closed
tniessen
wants to merge
1
commit into
nodejs:master
from
tniessen:crypto-simplify-getpublicorprivatekeyfromjs
Closed
crypto: simplify GetPublicOrPrivateKeyFromJs #26454
tniessen
wants to merge
1
commit into
nodejs:master
from
tniessen:crypto-simplify-getpublicorprivatekeyfromjs
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Issues and PRs that require attention from people who are familiar with C++.
crypto
Issues and PRs related to the crypto subsystem.
labels
Mar 5, 2019
bnoordhuis
approved these changes
Mar 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I felt it should have been an enum in the first place. :-)
addaleax
approved these changes
Mar 5, 2019
lpinca
approved these changes
Mar 5, 2019
jasnell
approved these changes
Mar 5, 2019
BridgeAR
approved these changes
Mar 5, 2019
BridgeAR
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Mar 5, 2019
shisama
approved these changes
Mar 6, 2019
Resume build: https://ci.nodejs.org/job/node-test-pull-request/21247/ |
Resume build: https://ci.nodejs.org/job/node-test-pull-request/21261/ |
Thanks for reviewing, everyone! Landed in 3e4e518. |
tniessen
added a commit
that referenced
this pull request
Mar 7, 2019
PR-URL: #26454 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Masashi Hirano <[email protected]>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
PR-URL: nodejs#26454 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Masashi Hirano <[email protected]>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
PR-URL: #26454 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Masashi Hirano <[email protected]>
tniessen
removed
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last argument is now always set to
true
due to #26278. This change removes said argument and its only usage in an assertion.Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes