Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process: delay creation of process.env until after bootstrap/node.js #26515

Closed
wants to merge 1 commit into from

Conversation

joyeecheung
Copy link
Member

Make sure that no code is allowed to access process.env during
the execution of bootstrap/node.js.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Make sure that no code is allowed to access process.env during
the execution of bootstrap/node.js.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 8, 2019
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@joyeecheung
Copy link
Member Author

joyeecheung commented Mar 8, 2019

@joyeecheung
Copy link
Member Author

joyeecheung commented Mar 11, 2019

New CI: https://ci.nodejs.org/job/node-test-pull-request/21423/ oops did not see the previous green CI.

@joyeecheung
Copy link
Member Author

Landed in ee2d263

joyeecheung added a commit that referenced this pull request Mar 11, 2019
Make sure that no code is allowed to access process.env during
the execution of bootstrap/node.js.

PR-URL: #26515
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BridgeAR
Copy link
Member

This does not land cleanly on v11. It seems to rely on other commits that should be backported first. Please open a manual backport for it or change the labels accordingly.

targos pushed a commit that referenced this pull request Mar 27, 2019
Make sure that no code is allowed to access process.env during
the execution of bootstrap/node.js.

PR-URL: #26515
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants