Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove usage of deprecated IsNearDeath #26630

Closed
wants to merge 1 commit into from
Closed

src: remove usage of deprecated IsNearDeath #26630

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Mar 13, 2019

@nodejs-github-bot
Copy link
Collaborator

@targos build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2890/pipeline

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Mar 13, 2019
@targos
Copy link
Member Author

targos commented Mar 13, 2019

CI: https://ci.nodejs.org/job/node-test-pull-request/21503/

@targos targos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 13, 2019
@Flarna Flarna mentioned this pull request Mar 15, 2019
Merged
@targos
Copy link
Member Author

targos commented Mar 15, 2019

Landed in c32615c

@targos targos closed this Mar 15, 2019
@targos targos deleted the no-isneardeath branch March 15, 2019 14:59
targos added a commit that referenced this pull request Mar 15, 2019
@targos
src: remove usage of deprecated IsNearDeath
c32615c 
Refs: v8/v8@06193b0

PR-URL: #26630
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit to targos/node that referenced this pull request Mar 27, 2019
@targos
src: remove usage of deprecated IsNearDeath
4bf7138 
Refs: v8/v8@06193b0

PR-URL: nodejs#26630
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
targos added a commit that referenced this pull request Mar 27, 2019
@targos
src: remove usage of deprecated IsNearDeath
925b645 
Refs: v8/v8@06193b0

PR-URL: #26630
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@targos targos mentioned this pull request Mar 27, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@targos @BethGriggs
src: remove usage of deprecated IsNearDeath
84db29c 
Refs: v8/v8@06193b0

PR-URL: #26630
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@targos @nodejs-github-bot @bnoordhuis @jasnell @addaleax @cjihrig @tniessen @joyeecheung @BridgeAR