Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools,doc: standardize RFC name formatting #26727

Closed
wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 18, 2019

First commit:

doc: make RFC references consistent

Use "RFC 1234" instead of "rfc1234", "RFC1234" or similar variants.

Second commit:

tools: update lint-md.js to lint rfc name format

Update lint-md.js to lint for "RFC1234" and similar variants that should
be written as "RFC 1234".
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Use "RFC 1234" instead of "rfc1234", "RFC1234" or similar variants.
Update lint-md.js to lint for "RFC1234" and similar variants that should
be written as "RFC 1234".
@Trott Trott requested a review from richardlau March 18, 2019 04:36
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 18, 2019
@Trott
Copy link
Member Author

Trott commented Mar 18, 2019

👍 here to fast track.

@Trott Trott added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 18, 2019
@vsemozhetbyt vsemozhetbyt added the doc Issues and PRs related to the documentations. label Mar 18, 2019
@Trott
Copy link
Member Author

Trott commented Mar 18, 2019

Landed in 0a00933...72f5783

@Trott Trott closed this Mar 18, 2019
Trott added a commit that referenced this pull request Mar 18, 2019
Use "RFC 1234" instead of "rfc1234", "RFC1234" or similar variants.

PR-URL: #26727
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Trott added a commit that referenced this pull request Mar 18, 2019
Update lint-md.js to lint for "RFC1234" and similar variants that should
be written as "RFC 1234".

PR-URL: #26727
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
Use "RFC 1234" instead of "rfc1234", "RFC1234" or similar variants.

PR-URL: nodejs#26727
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
Update lint-md.js to lint for "RFC1234" and similar variants that should
be written as "RFC 1234".

PR-URL: nodejs#26727
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
Use "RFC 1234" instead of "rfc1234", "RFC1234" or similar variants.

PR-URL: #26727
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
Update lint-md.js to lint for "RFC1234" and similar variants that should
be written as "RFC 1234".

PR-URL: #26727
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
@Trott Trott deleted the update-lint-md branch January 13, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants