Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module: remove usage of require('util') #26805

Closed

Conversation

dnlup
Copy link
Contributor

@dnlup dnlup commented Mar 20, 2019

Use require('internal/util/debuglog').debuglog instead of
require('util').debuglog in lib/internal/modules/esm/module_map.js.

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Use `require('internal/util/debuglog').debuglog` instead of 
`require('util').debuglog` in `lib/internal/modules/esm/module_map.js`.

Refs: nodejs#26546
@BridgeAR
Copy link
Member

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
@BridgeAR
Copy link
Member

@ZYSzys
Copy link
Member

ZYSzys commented Mar 24, 2019

Landed in 25b78c0 🎉

@ZYSzys ZYSzys closed this Mar 24, 2019
ZYSzys pushed a commit that referenced this pull request Mar 24, 2019
Use `require('internal/util/debuglog').debuglog` instead of
`require('util').debuglog` in `lib/internal/modules/esm/module_map.js`.

Refs: #26546

PR-URL: #26805
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
Use `require('internal/util/debuglog').debuglog` instead of
`require('util').debuglog` in `lib/internal/modules/esm/module_map.js`.

Refs: nodejs#26546

PR-URL: nodejs#26805
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
Use `require('internal/util/debuglog').debuglog` instead of
`require('util').debuglog` in `lib/internal/modules/esm/module_map.js`.

Refs: #26546

PR-URL: #26805
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@dnlup dnlup deleted the util_internal_modules_esm_module_map branch January 10, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants