Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

url: remove usage of require('util')  #26808

Closed
wants to merge 1 commit into from

Conversation

toshi1127
Copy link
Contributor

Remove the usage of public require('util').
Use require('internal/util/inspect').inspect instead of require('util').inspect.
Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@jasnell
Copy link
Member

jasnell commented Mar 21, 2019

@nodejs/tsc ... just a quick note: we need to be clear on how these kinds of changes need to be handled semver-wise. This change, for instance, changes the monkey-patch-ability of util.inspect() in this case. Is that an ok thing to do for a semver-patch or should breaking monkey-patching be considered semver-major always?

@targos
Copy link
Member

targos commented Mar 21, 2019

I think we should generally consider this semver-patch. It is not part of the API contract of the URL module that the util.inspect function is used internally in its methods.

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
@BridgeAR
Copy link
Member

@ZYSzys
Copy link
Member

ZYSzys commented Mar 24, 2019

Landed in 5b59b5f 🎉

@ZYSzys ZYSzys closed this Mar 24, 2019
ZYSzys pushed a commit that referenced this pull request Mar 24, 2019
PR-URL: #26808
Refs: #26546
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
PR-URL: nodejs#26808
Refs: nodejs#26546
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
targos pushed a commit that referenced this pull request Mar 27, 2019
PR-URL: #26808
Refs: #26546
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants