src: apply clang-tidy readability-delete-null-pointer #26813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
refack
approved these changes
Mar 20, 2019
|
@gengjiawen I think you should add a CI: https://ci.nodejs.org/job/node-test-pull-request/21696/ |
|
yeap, but I am still working on a way to ensure the rules. |
|
Very preliminary https://ci.nodejs.org/job/node-clang-tidy/1/console |
bnoordhuis
approved these changes
Mar 20, 2019
refack
added
the
author ready
richardlau
approved these changes
Mar 20, 2019
2 tasks
addaleax
approved these changes
Mar 21, 2019
PR-URL: nodejs#26813 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
refack
force-pushed
the
readability-delete-null-pointer
branch
from
6838311
to
c757cb1
Compare
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 27, 2019
PR-URL: nodejs#26813 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
targos
pushed a commit
that referenced
this pull request
Mar 27, 2019
PR-URL: #26813 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: https://isocpp.org/wiki/faq/freestore-mgmt#delete-handles-null and https://clang.llvm.org/extra/clang-tidy/checks/readability-delete-null-pointer.html.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes