Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

worker: remove usage of require('util') in worker_thread.js #26814

Closed
wants to merge 1 commit into from
Closed

worker: remove usage of require('util') in worker_thread.js #26814

wants to merge 1 commit into from

Conversation

toshi1127
Copy link
Contributor

Use require('internal/util/debuglog').debuglog instead of
require('util').debuglog in lib/internal/main/worker_thread.js.

Refs: #26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]

@joyeecheung joyeecheung mentioned this pull request Mar 20, 2019
Closed
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21804/

@shisama shisama added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support. labels Mar 24, 2019
@ZYSzys
Copy link
Member

ZYSzys commented Mar 24, 2019

Landed in 740e7e8 🎉

@ZYSzys ZYSzys closed this Mar 24, 2019
ZYSzys pushed a commit that referenced this pull request Mar 24, 2019
@toshi1127 @ZYSzys
worker: remove usage of require('util') in worker_thread.js
740e7e8 
PR-URL: #26814
Refs: #26546
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
targos pushed a commit that referenced this pull request Mar 28, 2019
@toshi1127 @targos
worker: remove usage of require('util') in worker_thread.js
652e5f8 
PR-URL: #26814
Refs: #26546
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
targos pushed a commit that referenced this pull request Mar 30, 2019
@toshi1127 @targos
worker: remove usage of require('util') in worker_thread.js
5d9f819 
PR-URL: #26814
Refs: #26546
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Masashi Hirano <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@shisama shisama shisama approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@toshi1127 @BridgeAR @ZYSzys @jasnell @targos @shisama