Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test of policy about parse error #26873

Closed
wants to merge 2 commits into from
Closed

test: add test of policy about parse error #26873

wants to merge 2 commits into from

Conversation

sasurau4
Copy link
Contributor

@sasurau4 sasurau4 commented Mar 23, 2019 •
edited
Loading

Add test cases of policy when the error ERR_SRI_PARSE occurs.
The current coverage about sri is here.

I add a new file test-policy-parse-integrity.js because I think it's too complicated when I enhanced the test-policy-integrity.js to pass the invalid integrity string.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 23, 2019
@sasurau4 sasurau4 marked this pull request as ready for review March 23, 2019 00:54
@BridgeAR
Copy link
Member

@nodejs/testing PTAL

BridgeAR
BridgeAR approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it would be nice to address the comments before landing.

test/parallel/test-policy-parse-integrity.js Outdated Show resolved Hide resolved
test/parallel/test-policy-parse-integrity.js Show resolved Hide resolved
@sasurau4
Copy link
Contributor Author

sasurau4 commented Apr 16, 2019 •
edited
Loading

@BridgeAR Thanks for your review. I fixed that you pointed out. 👍

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 16, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22502/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22824/

@Trott
Copy link
Member

Trott commented Apr 29, 2019

Landed in a565853

@Trott Trott closed this Apr 29, 2019
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 29, 2019
@sasurau4 @Trott
test: add test of policy about parse error
a565853 
PR-URL: nodejs#26873
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request Apr 30, 2019
@sasurau4 @targos
test: add test of policy about parse error
0dfe5be 
PR-URL: #26873
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request May 6, 2019
Merged
This was referenced May 7, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sasurau4 @BridgeAR @nodejs-github-bot @Trott