Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove test-path-parse-6229.js from known issues #26913

Closed
wants to merge 1 commit into from

Conversation

BridgeAR
Copy link
Member

This test precedented the official documentation that states that
this is an expected behavior.

Refs: #6229
Refs: #12181

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

This test precedented the official documentation that states that
this is an expected behavior.

Refs: nodejs#6229
Refs: nodejs#12181
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 26, 2019
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR
Copy link
Member Author

@nodejs/testing PTAL

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 28, 2019
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 29, 2019
This test precedented the official documentation that states that
this is an expected behavior.

PR-URL: nodejs#26913
Refs: nodejs#6229
Refs: nodejs#12181
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
@BridgeAR
Copy link
Member Author

Landed in f9da55c.

@BridgeAR BridgeAR closed this Mar 29, 2019
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
This test precedented the official documentation that states that
this is an expected behavior.

PR-URL: #26913
Refs: #6229
Refs: #12181
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
BethGriggs pushed a commit that referenced this pull request Apr 8, 2019
This test precedented the official documentation that states that
this is an expected behavior.

PR-URL: #26913
Refs: #6229
Refs: #12181
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Signed-off-by: Beth Griggs <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Apr 9, 2019
@BridgeAR BridgeAR deleted the remove-faulty-known-issue branch January 20, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants