Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finish test coverage for lib/internal/dns/utils.js #27006

Closed
wants to merge 2 commits into from
Closed

finish test coverage for lib/internal/dns/utils.js #27006

wants to merge 2 commits into from

Commits on Mar 30, 2019

  1. dns: refactor lib/internal/dns/utils.js 

    * alphabetize contenst of `resolverKeys` array
* less line-wrapping for increased code clarity
    @Trott
    Trott committed Mar 30, 2019
    Configuration menu
    Copy the full SHA
    caedd72 View commit details
    Browse the repository at this point in the history

  2. test: add IPv6 brackets but no port to test-dns 

    Add a test case to test-dns to check that supply an IPv6 host with
brackets but no explicit port to `dns.setServers()` yields expected
results. This is the final bit of test coverage missing for
lib/internal/dns/utils.js.
    @Trott
    Trott committed Mar 30, 2019
    Configuration menu
    Copy the full SHA
    2e4719f View commit details
    Browse the repository at this point in the history