Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some clang-tidy issue and small refactor #27152

Merged
merged 2 commits into from
Apr 11, 2019
Merged

Fix some clang-tidy issue and small refactor #27152

merged 2 commits into from
Apr 11, 2019

Commits on Apr 11, 2019

  1. src: use macro instead of magic number for fd 

    PR-URL: nodejs#27152
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @gengjiawen @refack
    gengjiawen authored and refack committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    845a621 View commit details
    Browse the repository at this point in the history

  2. src: remove redundant string initialization 

    PR-URL: nodejs#27152
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @gengjiawen @refack
    gengjiawen authored and refack committed Apr 11, 2019
    Configuration menu
    Copy the full SHA
    ee7daf7 View commit details
    Browse the repository at this point in the history