Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11.x] deps: V8: backport 61f4c22 #27259

Closed

Conversation

addaleax
Copy link
Member

The differences to the original patch are the replacement of
i::IsIdentifier...() with unicode_cache_.IsIdentifier...(),
because the former is not available on Node.js v11.x, as well
as the omitted no_gc argument for GetFlatContent().

Original commit message:

Assume flat string when checking CompileFunctionInContext arguments.

[email protected]

Change-Id: I54c6137a3c6e14d4102188f154aa7216e7414dbc
Reviewed-on: https://chromium-review.googlesource.com/c/1388533
Reviewed-by: Jakob Kummerow <[email protected]>
Commit-Queue: Yang Guo <[email protected]>
Cr-Commit-Position: refs/heads/master@{#58562}

Refs: v8/v8@61f4c22
Fixes: #27256

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

The differences to the original patch are the replacement of
`i::IsIdentifier...()` with `unicode_cache_.IsIdentifier...()`,
because the former is not available on Node.js v11.x, as well
as the omitted `no_gc` argument for `GetFlatContent()`.

Original commit message:

    Assume flat string when checking CompileFunctionInContext arguments.

    [email protected]

    Change-Id: I54c6137a3c6e14d4102188f154aa7216e7414dbc
    Reviewed-on: https://chromium-review.googlesource.com/c/1388533
    Reviewed-by: Jakob Kummerow <[email protected]>
    Commit-Queue: Yang Guo <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#58562}

Refs: v8/v8@61f4c22
Fixes: nodejs#27256
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v11.x v8 engine Issues and PRs related to the V8 dependency. labels Apr 16, 2019
@nodejs-github-bot
Copy link
Collaborator

@addaleax
Copy link
Member Author

@addaleax addaleax changed the title deps: V8: backport 61f4c22 [v11.x] deps: V8: backport 61f4c22 Apr 16, 2019
@addaleax addaleax removed the build Issues and PRs related to build files or the CI. label Apr 16, 2019
@nodejs-github-bot
Copy link
Collaborator

@BridgeAR BridgeAR mentioned this pull request Apr 21, 2019
codebytere pushed a commit that referenced this pull request Apr 29, 2019
The differences to the original patch are the replacement of
`i::IsIdentifier...()` with `unicode_cache_.IsIdentifier...()`,
because the former is not available on Node.js v11.x, as well
as the omitted `no_gc` argument for `GetFlatContent()`.

Original commit message:

    Assume flat string when checking CompileFunctionInContext arguments.

    [email protected]

    Change-Id: I54c6137a3c6e14d4102188f154aa7216e7414dbc
    Reviewed-on: https://chromium-review.googlesource.com/c/1388533
    Reviewed-by: Jakob Kummerow <[email protected]>
    Commit-Queue: Yang Guo <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#58562}

Refs: v8/v8@61f4c22
Fixes: #27256

PR-URL: #27259
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
@codebytere
Copy link
Member

Landed in 7da23dc

@richardlau
Copy link
Member

Tried to cherry-pick this to v10.x-staging but it fails to compile and would need to be manually backported (if at all).
https://travis-ci.com/github/nodejs/node/builds/188610323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants