Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix extname with the correct description #27303

Closed
wants to merge 1 commit into from
Closed

doc: fix extname with the correct description #27303

wants to merge 1 commit into from

Conversation

himself65
Copy link
Member

fix #27292

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem. labels Apr 19, 2019
@himself65
Copy link
Member Author 

doc/api/path.md
  160:73  warning  Remove trailing whitespace  no-trailing-spaces  remark-lint

Trott
Trott reviewed Apr 19, 2019
View reviewed changes
doc/api/path.md Outdated Show resolved Hide resolved
Trott
Trott reviewed Apr 19, 2019
View reviewed changes
doc/api/path.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Apr 19, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3300/

@himself65
Copy link
Member Author

himself65 commented Apr 19, 2019 •
edited
Loading

have squashed

@Trott
Copy link
Member

Trott commented Apr 19, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3307/

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 20, 2019
@vsemozhetbyt
Copy link
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@vsemozhetbyt vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 20, 2019
@vsemozhetbyt
Copy link
Contributor

Landed in 290faec
Thank you!

vsemozhetbyt pushed a commit that referenced this pull request Apr 20, 2019
@himself65 @vsemozhetbyt
doc: fix extname with the correct description
290faec 
PR-URL: #27303
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@beevelop beevelop mentioned this pull request Apr 23, 2019
Closed
@molllyn1 molllyn1 mentioned this pull request Apr 15, 2024
Open
@ron-a20 ron-a20 mentioned this pull request Apr 15, 2024
Open
@kissofire kissofire mentioned this pull request Apr 15, 2024
Open
@137717unity 137717unity mentioned this pull request Apr 15, 2024
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Apr 15, 2024
Open
@wedataintelligence wedataintelligence mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@BeniCheni BeniCheni BeniCheni approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. path Issues and PRs related to the path subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

path.extname('.a.a')!=''
7 participants
@himself65 @Trott @vsemozhetbyt @BeniCheni @BridgeAR @ZYSzys @nodejs-github-bot