doc: outline that process.stdin emits multiple readable events #27350
Conversation
nodejs-github-bot
added
doc
BridgeAR
changed the title
doc/api/process.md
Outdated
|
|
||
| In "old" streams mode the `stdin` stream is paused by default, so one | ||
| must call `process.stdin.resume()` to read from it. Note also that calling | ||
| `process.stdin.resume()` itself would switch stream to "old" mode. |
There was a problem hiding this comment.
I would prefer we did not mention "old" stream mode in this docs. A user can add a 'data' event to start reading as well, it's part of the documented API.
There was a problem hiding this comment.
This text is not something I added btw, I just moved it around. I'm happy to remove it though. Please be very specific about which part to remove or any alternative wording (I am just a casual node.js user so I don't have a good idea what is appropriate)
There was a problem hiding this comment.
Ok! let's keep the text for now.
|
@ronag PTAL |
|
Doesn’t this apply to streams in general? I haven’t looked at the specifics but if we’re changing anything shouldn’t that be in the streams docs? |
|
i.e. I think any improvements should go into https://nodejs.org/dist/latest-v13.x/docs/api/stream.html#stream_readable_streams. Unless there is something special about stdin I would suggest removing/moving the example from stdin doc, add more explicit link to streams documentation and maybe improve the stream docs with further examples and clarification. |
|
@anentropic, can you follow up with review comments ? |
re @Ronal's comments in January... It looks to me that we should move/copy(?) the relevant parts of changed paragraph and example code from Please confirm, and whether to move it or copy it |
|
Ping @ronag, I guess @anentropic miss spelled your name. |
I would personally prefer to move it and add a link in its place. |
anentropic
force-pushed
the
stdin-docs
branch
5 times, most recently
from
0a2de14
to
dc6f8e8
Compare
|
Hi all, thanks for your reviews and feedback. I have amended my changes, hopefully in line with everyone's preferences. Let me know any further tweaks needed. |
…t from process.html stdin
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff
to
2935f72
Compare
document more clearly that stdin will emit multiple readable events PR-URL: #27350 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in 7c9df66 |
document more clearly that stdin will emit multiple readable events PR-URL: #27350 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]>
document more clearly that stdin will emit multiple readable events PR-URL: #27350 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]>
document more clearly that stdin will emit multiple readable events PR-URL: #27350 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: James M Snell <[email protected]>
I commented here: #20503 (comment)
Basically I found the current docs quite unclear about the behaviour of
process.stdin, particularly with regards to reading a large file from stdin.@mcollina suggested making a PR to improve the docs, so here is my attempt.
I have adjusted the code comments in the existing js example (as I found them misleading for my purposes). I have added a new paragraph, derived from @mcollina 's comment here #20503 (comment) to try to explain the actual behaviour. Finally I have added a second code example reflecting what I think is a more typical use case.
Please review these carefully for terminology and accuracy, I don't have much experience with node.js
Checklist