Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: V8: cherry-pick 94c87fe #27792

Closed
wants to merge 1 commit into from
Closed

deps: V8: cherry-pick 94c87fe #27792

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented May 21, 2019

Original commit message:

[ic] Fix handling of +0/-0 when constant field tracking is enabled

... and ensure that runtime behaviour is in sync with the IC code.

Bug: chromium:950747, v8:9113
Change-Id: Ied66c9514cbe3a4d75fc71d4fc3b19ea1538f9b2
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561319
Reviewed-by: Toon Verwaest <[email protected]>
Commit-Queue: Igor Sheludko <[email protected]>
Cr-Commit-Position: refs/heads/master@{#60768}

Refs: v8/v8@94c87fe

Fixes: #27784

Original commit message:

    [ic] Fix handling of +0/-0 when constant field tracking is enabled

    ... and ensure that runtime behaviour is in sync with the IC code.

    Bug: chromium:950747, v8:9113
    Change-Id: Ied66c9514cbe3a4d75fc71d4fc3b19ea1538f9b2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561319
    Reviewed-by: Toon Verwaest <[email protected]>
    Commit-Queue: Igor Sheludko <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#60768}

Refs: v8/v8@94c87fe
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency. labels May 21, 2019
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 21, 2019

@BridgeAR
Copy link
Member

I would like to fast track this PR to get it into a patch release tomorrow.

Please +1 if you agree.

@nodejs-github-bot
Copy link
Collaborator

@BridgeAR
Copy link
Member

@addaleax @devsnek @targos @bnoordhuis @nodejs/v8-update are you fine to fast track this for the patch release today? This seems like a pretty bad bug to me that should be fixed soon.

@BridgeAR BridgeAR mentioned this pull request May 22, 2019
@BridgeAR BridgeAR added the fast-track PRs that do not need to wait for 48 hours to land. label May 22, 2019
@BridgeAR
Copy link
Member

Landed in f2fe1e5 🎉

@BridgeAR BridgeAR closed this May 22, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 22, 2019
Original commit message:

    [ic] Fix handling of +0/-0 when constant field tracking is enabled

    ... and ensure that runtime behaviour is in sync with the IC code.

    Bug: chromium:950747, v8:9113
    Change-Id: Ied66c9514cbe3a4d75fc71d4fc3b19ea1538f9b2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561319
    Reviewed-by: Toon Verwaest <[email protected]>
    Commit-Queue: Igor Sheludko <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#60768}

PR-URL: nodejs#27792
Fixes: nodejs#27784
Refs: v8/v8@94c87fe
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@targos targos deleted the fix-27784 branch May 22, 2019 11:29
@targos
Copy link
Member Author

targos commented May 22, 2019

I don't know if it's related but the linux-perf test failed: https://ci.nodejs.org/job/node-test-commit-v8-linux/2293/nodes=benchmark-ubuntu1604-intel-64,v8test=v8test/console

BridgeAR pushed a commit that referenced this pull request May 22, 2019
Original commit message:

    [ic] Fix handling of +0/-0 when constant field tracking is enabled

    ... and ensure that runtime behaviour is in sync with the IC code.

    Bug: chromium:950747, v8:9113
    Change-Id: Ied66c9514cbe3a4d75fc71d4fc3b19ea1538f9b2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1561319
    Reviewed-by: Toon Verwaest <[email protected]>
    Commit-Queue: Igor Sheludko <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#60768}

PR-URL: #27792
Fixes: #27784
Refs: v8/v8@94c87fe
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
@BridgeAR
Copy link
Member

@targos those already failed before. There is some issue around the benchmark test currently.

BridgeAR added a commit that referenced this pull request May 22, 2019
Notable changes

* deps:
  * Fix handling of +0/-0 when constant field tracking is enabled
    (Michaël Zasso) #27792
  * Fix `os.freemem()` and `os.totalmem` correctness (cjihrig)
    #27718
* src:
  * Fix v12.3.0 regression that prevents native addons from compiling
    #27804

PR-URL: #27814
BridgeAR added a commit to BridgeAR/node that referenced this pull request May 22, 2019
Notable changes

* deps:
  * Fix handling of +0/-0 when constant field tracking is enabled
    (Michaël Zasso) nodejs#27792
  * Fix `os.freemem()` and `os.totalmem` correctness (cjihrig)
    nodejs#27718
* src:
  * Fix v12.3.0 regression that prevents native addons from compiling
    nodejs#27804

PR-URL: nodejs#27814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. fast-track PRs that do not need to wait for 48 hours to land. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to reassign negative zero object property to positive zero
6 participants