Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tls: support the hints option #27816

Closed
wants to merge 2 commits into from
Closed

tls: support the hints option #27816

wants to merge 2 commits into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented May 22, 2019

Make tls.connect() support the hints option for feature parity with
net.connect().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@lpinca
tls: support the hints option
53f9983 
Make `tls.connect()` support the `hints` option for feature parity with
`net.connect()`.
@nodejs-github-bot
Copy link
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3594

@nodejs-github-bot nodejs-github-bot added the tls Issues and PRs related to the tls subsystem. label May 22, 2019
@BridgeAR
Copy link
Member

@lpinca thanks for unifying all these options!

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23270/

sam-github
sam-github reviewed May 22, 2019
View reviewed changes
doc/api/tls.md Show resolved Hide resolved
lib/_tls_wrap.js Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23288/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23318/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23319/

@lpinca
Copy link
Member Author

lpinca commented May 25, 2019

Landed in ff8539e.

@lpinca lpinca closed this May 25, 2019
@lpinca lpinca deleted the support/hints-option branch May 25, 2019 06:51
lpinca added a commit that referenced this pull request May 25, 2019
@lpinca
tls: support the hints option
ff8539e 
Make `tls.connect()` support the `hints` option for feature parity with
`net.connect()`.

PR-URL: #27816
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
targos pushed a commit that referenced this pull request May 28, 2019
@lpinca @targos
tls: support the hints option
10e0d7f 
Make `tls.connect()` support the `hints` option for feature parity with
`net.connect()`.

PR-URL: #27816
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Sam Roberts <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sam-github sam-github sam-github approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@ZYSzys ZYSzys ZYSzys approved these changes

Assignees
No one assigned
Labels
tls Issues and PRs related to the tls subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@lpinca @nodejs-github-bot @BridgeAR @sam-github @jasnell @Trott @addaleax @cjihrig @ZYSzys