-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add util inspect null getter test #27884
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. /cc @BridgeAR
@mihan007 Could you take a look at the linter failures?
|
@addaleax fixed |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Failure:
Completely unrelated to the PR, I guess? |
The tests pass but there's a... performance regression? |
@ryzokuken Can you elaborate on that? I'm not sure what you're referring to but I am certainly curious. |
@Trott according to https://ci.nodejs.org/job/node-test-commit/28968/, all tests passed, but https://ci.nodejs.org/job/node-test-commit-linux-containered/nodes=ubuntu1604_sharedlibs_debug_x64/13006/testReport/junit/(root)/test/sequential_test_performance/ reports a performance regression. |
Ah! test-performance isn't a performance regression test. It's a test of the |
@Trott I see! Sorry for misunderstanding. |
No worries! The only reason I know that is because I made the same exact mistake in the past! The test might benefit from being renamed |
@Trott I could make a PR 🤷♂ |
Rename test-performance to test-perf-hooks to better match its function Refs: nodejs#27884 (comment)
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
PR-URL: nodejs#27884 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Landed in 1dbf276 |
Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
PR-URL: #27884 Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]>
Rename test-performance to test-perf-hooks to better match its function Refs: #27884 (comment) PR-URL: #27969 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Rename test-performance to test-perf-hooks to better match its function Refs: #27884 (comment) PR-URL: #27969 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passes