Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

console: fix table() output #27917

Closed
wants to merge 1 commit into from
Closed

console: fix table() output #27917

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented May 26, 2019

Fixes: #27915

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@mscdex mscdex added the console Issues and PRs related to the console subsystem. label May 26, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23353/

@devsnek
Copy link
Member

devsnek commented May 26, 2019

can we just remove the thingy that adds weird string addition to the output of util.inspect? i feel like this fixes a symptom rather than the problem.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/23419/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 29, 2019
@Trott
Copy link
Member

Trott commented May 30, 2019

can we just remove the thingy that adds weird string addition to the output of util.inspect? i feel like this fixes a symptom rather than the problem.

I'm going to land this to get at least a minimal fix but no objection at all to a separate PR to try to simplify the util.inspect implementation.

Trott pushed a commit to Trott/io.js that referenced this pull request May 30, 2019
@mscdex @Trott
console: fix table() output
b8bdf0e 
Fixes: nodejs#27915

PR-URL: nodejs#27917
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@Trott
Copy link
Member

Trott commented May 30, 2019

Landed in b8bdf0e

@Trott Trott closed this May 30, 2019
targos pushed a commit that referenced this pull request May 31, 2019
@mscdex @targos
console: fix table() output
449ee8d 
Fixes: #27915

PR-URL: #27917
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
@targos targos mentioned this pull request Jun 3, 2019
Merged
@mscdex mscdex deleted the console-fix-table-output branch July 8, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. console Issues and PRs related to the console subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

console.table splits long strings and breaks formatting in node v12
7 participants
@mscdex @nodejs-github-bot @devsnek @Trott @lpinca @BridgeAR @trivikr