Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] http, http2: flag for overriding server timeout #27939

Closed
wants to merge 1 commit into from

Conversation

ofrobots
Copy link
Contributor

This is the 10.x backport of #27704.

Make it possible to override the default http server timeout. Ideally
there should be no server timeout - as done on the master branch. This
is a non-breaking way to enable platform providers to override the
value.

PR-URL: #27704
Refs: #27558
Refs: #27556
Reviewed-By: Anna Henningsen [email protected]
Reviewed-By: Myles Borins [email protected]
Reviewed-By: Ruben Bridgewater [email protected]

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Make it possible to override the default http server timeout. Ideally
there should be no server timeout - as done on the master branch. This
is a non-breaking way to enable platform providers to override the
value.

PR-URL: nodejs#27704
Refs: nodejs#27558
Refs: nodejs#27556
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@ofrobots ofrobots added the v10.x label May 28, 2019
@nodejs-github-bot
Copy link
Collaborator

@ofrobots
Copy link
Contributor Author

@nodejs/lts this is good to land - and only y'all can land on 10.x-staging. Perhaps we should wait for the 12.x version of it to be released first? Either way, your call.

@addaleax addaleax added http Issues or PRs related to the http subsystem. http2 Issues or PRs related to the http2 subsystem. labels Jun 2, 2019
@BethGriggs BethGriggs added the baking-for-lts PRs that need to wait before landing in a LTS release. label Jun 6, 2019
BethGriggs pushed a commit that referenced this pull request Jun 25, 2019
Make it possible to override the default http server timeout. Ideally
there should be no server timeout - as done on the master branch. This
is a non-breaking way to enable platform providers to override the
value.

Backport-PR-URL: #27939
PR-URL: #27704
Refs: #27558
Refs: #27556
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggs BethGriggs removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Jun 25, 2019
@BethGriggs
Copy link
Member

Landed on v10.x-staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http Issues or PRs related to the http subsystem. http2 Issues or PRs related to the http2 subsystem. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants