Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: use getter replace use directly _witableState.finished #28007

Closed
wants to merge 2 commits into from
Closed

http2: use getter replace use directly _witableState.finished #28007

wants to merge 2 commits into from
+93 −4

Commits on Jun 24, 2019

  1. stream: add writableFinished 

    add a new getter to duplex stream to replace the property `this
.writableState.finished` of the object that inherited duplex.

Refs: nodejs#445
    @zero1five
    zero1five committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    5cd6ccc View commit details
    Browse the repository at this point in the history

  2. http2: use writableFinished instead of _writableState

    @zero1five
    zero1five committed Jun 24, 2019
    Configuration menu
    Copy the full SHA
    2c66f6c View commit details
    Browse the repository at this point in the history