Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cherry-pick 6da51b4 from v8's upstream #2801

Closed
wants to merge 1 commit into from

Commits on Sep 10, 2015

  1. deps: cherry-pick 6da51b4 from v8's upstream

    Original commit message:
    
        TypedArray accessor detection: consider entire prototype chain
    
        When looking up a special accessor for known TypedArray fields
        ("length", "byteLength", "byteOffset"), consider the entire
        prototype chain, not only the direct prototype.
        This allows subclasses of TypedArrays to benefit from fast
        specialized accesses.
    
        Review URL: https://codereview.chromium.org/1313493005
    
        Cr-Commit-Position: refs/heads/master@{nodejs#30678}
    
    Benchmark results:
    
       buffers/buffer-iterate.js size=16386 type=slow method=for n=1000:
       ./node: 71607 node: 8702.3 ............ 722.85%
    
    Improvement depends on the code, but generally brings us back to the
    performance that we had before the v8 update (if not making it
    faster).
    indutny committed Sep 10, 2015
    Configuration menu
    Copy the full SHA
    be2822d View commit details
    Browse the repository at this point in the history