Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 7.6 #28016

Closed
wants to merge 20 commits into from
Closed

deps: update V8 to 7.6 #28016

wants to merge 20 commits into from

Conversation

ryzokuken
Copy link
Contributor

🎉
Thanks @targos @refack

@cjihrig could you PTAL at 9106789138?

@ryzokuken ryzokuken requested review from refack and targos June 2, 2019 10:24
@ryzokuken
Copy link
Contributor Author

/cc @nodejs/v8-update

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos

This comment has been minimized.

Sign in to view
@targos targos force-pushed the v8-7.6 branch 2 times, most recently from 28704ed to fe8bf54 Compare June 2, 2019 11:28
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 2, 2019 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/23554/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/2345/

@targos

This comment has been minimized.

Sign in to view
@targos
Copy link
Member

targos commented Jun 2, 2019

@cjihrig Along with 9106789 (which I had to do to make it compile), we have some missing constants: v8dbg_class_FixedTypedArrayBase__base_pointer__Object,v8dbg_class_FixedTypedArrayBase__external_pointer__uintptr_t,v8dbg_class_Map__instance_descriptors_offset

@targos
Copy link
Member

targos commented Jun 2, 2019

@nodejs/platform-ppc @nodejs/platform-s390 we have some segfaults in V8 tests: https://ci.nodejs.org/job/node-test-commit-v8-linux/2345/nodes=ppcle-ubuntu1404,v8test=v8test/ https://ci.nodejs.org/job/node-test-commit-v8-linux/2345/nodes=rhel72-s390x,v8test=v8test/

@refack

This comment has been minimized.

Sign in to view
@miladfarca
Copy link
Contributor

miladfarca commented Jun 2, 2019 •
edited
Loading

s390 and ppc are segfaulting on some tests because of this CL: https://chromium-review.googlesource.com/c/v8/v8/+/1632235, we have a solution but waiting on the original owner to get back to us on a question first.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@targos targos added semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency. labels Jun 2, 2019
@targos

This comment has been minimized.

Sign in to view
@cjihrig
Copy link
Contributor

cjihrig commented Jun 2, 2019

@cjihrig could you PTAL at 9106789?

Sure thing.

@refack
Copy link
Contributor

refack commented Jun 2, 2019

😱 what happened to aix??

It get's that way from time to time.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs nodejs deleted a comment from nodejs-github-bot Jun 2, 2019
@refack

This comment has been minimized.

Sign in to view
@miladfarca
Copy link
Contributor

miladfarca commented Jun 2, 2019 •
edited
Loading

@refack the flaky test? might be an undefined behaviour where it passes or fails form time to time (due to this CL: https://chromium-review.googlesource.com/c/v8/v8/+/1561072), will be looking into it using V8 master.

@cjihrig
Copy link
Contributor

cjihrig commented Jun 3, 2019

@ryzokuken / @targos can you try cherry-picking in cjihrig@19d7b31 and cjihrig@9e50c0a.

@ryzokuken
Copy link
Contributor Author

@cjihrig @targos @refack fixed and done! PTAL. Making this PR ready for review. 🎉

@ryzokuken ryzokuken marked this pull request as ready for review June 3, 2019 15:17
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Oct 30, 2019
@refack @nodejs-ci
deps: V8: fix filename manipulation for Windows
34ac235 
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Oct 30, 2019
@refack @nodejs-ci
deps: V8: add workaround for MSVC optimizer bug
c1e7380 
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Oct 30, 2019
@refack @nodejs-ci
deps: V8: fix linking issue for MSVS
1ac6ee9 
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Oct 31, 2019
@refack @nodejs-ci
deps: V8: fix filename manipulation for Windows
e3cb7b9 
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Oct 31, 2019
@refack @nodejs-ci
deps: V8: add workaround for MSVC optimizer bug
9149067 
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Oct 31, 2019
@refack @nodejs-ci
deps: V8: fix linking issue for MSVS
22a996c 
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
ryzokuken pushed a commit that referenced this pull request Nov 1, 2019
@refack @ryzokuken
deps: V8: fix filename manipulation for Windows
6df5c38 
PR-URL: #28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
ryzokuken pushed a commit that referenced this pull request Nov 1, 2019
@refack @ryzokuken
deps: V8: add workaround for MSVC optimizer bug
253053e 
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: #28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
ryzokuken pushed a commit that referenced this pull request Nov 1, 2019
@refack @ryzokuken
deps: V8: fix linking issue for MSVS
b1f98e7 
PR-URL: #28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 1, 2019
@refack @nodejs-ci
deps: V8: fix filename manipulation for Windows
dd4ed59 
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 1, 2019
@refack @nodejs-ci
deps: V8: add workaround for MSVC optimizer bug
3bf8eb3 
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Nov 1, 2019
@refack @nodejs-ci
deps: V8: fix linking issue for MSVS
d9212fb 
PR-URL: nodejs/node#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 5, 2019
@refack @targos
deps: V8: fix filename manipulation for Windows
9d6145c 
PR-URL: nodejs#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 5, 2019
@refack @targos
deps: V8: add workaround for MSVC optimizer bug
d10f454 
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
targos pushed a commit to targos/node that referenced this pull request Dec 5, 2019
@refack @targos
deps: V8: fix linking issue for MSVS
8f161a0 
PR-URL: nodejs#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
MylesBorins pushed a commit to targos/node that referenced this pull request Jan 7, 2020
@refack @MylesBorins
deps: V8: fix filename manipulation for Windows
a063d11 
PR-URL: nodejs#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
MylesBorins pushed a commit to targos/node that referenced this pull request Jan 7, 2020
@refack @MylesBorins
deps: V8: add workaround for MSVC optimizer bug
2719f09 
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

PR-URL: nodejs#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
MylesBorins pushed a commit to targos/node that referenced this pull request Jan 7, 2020
@refack @MylesBorins
deps: V8: fix linking issue for MSVS
28a3845 
PR-URL: nodejs#28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2020
@refack @MylesBorins
deps: V8: fix filename manipulation for Windows
b28a85d 
Backport-PR-URL: #30109
PR-URL: #28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2020
@refack @MylesBorins
deps: V8: add workaround for MSVC optimizer bug
02b54af 
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

Backport-PR-URL: #30109
PR-URL: #28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jan 8, 2020
@refack @MylesBorins
deps: V8: fix linking issue for MSVS
35ce2f6 
Backport-PR-URL: #30109
PR-URL: #28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@refack @BethGriggs
deps: V8: fix filename manipulation for Windows
fdad5b6 
Backport-PR-URL: #30109
PR-URL: #28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@refack @BethGriggs
deps: V8: add workaround for MSVC optimizer bug
3d11924 
Refs: https://developercommunity.visualstudio.com/content/problem/512352/compiler-doesnt-finish-142027508.html

Backport-PR-URL: #30109
PR-URL: #28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@refack @BethGriggs
deps: V8: fix linking issue for MSVS
d89f874 
Backport-PR-URL: #30109
PR-URL: #28016
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@refack refack refack approved these changes

@targos targos Awaiting requested review from targos

Assignees

@ryzokuken ryzokuken

Labels
semver-major PRs that contain breaking changes and should be released in the next major version. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.