Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update link to website in README #28042

Closed
wants to merge 1 commit into from
Closed

update link to website in README #28042

wants to merge 1 commit into from

Conversation

yvesgurcan
Copy link

Hello !

This is a very simple PR to fix the link in the README of the project.

Checklist

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 3, 2019
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link was broken by #27926.

@@ -9,7 +9,7 @@
</p>

Node.js is a JavaScript runtime built on Chrome's V8 JavaScript engine. For
more information on using Node.js, see the [Node.js Website][].
more information on using Node.js, see the [Node.js Website](https://nodejs.org).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you instead add the link to bottom of this file? (e.g. undo just the Node.js Website change from #27926).

@Trott
Copy link
Member

Trott commented Jun 13, 2019

Welcome @yvesgurcan and thanks for the pull request. I'm going to close this in favor of #28119 as there's a comment on this one that has been unresolved for 9 days. (Which is totally OK. There are other things in the world to focus on besides GitHub etc. That said, if you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@Trott Trott closed this Jun 13, 2019
@yvesgurcan
Copy link
Author

yvesgurcan commented Jun 13, 2019

Hi Trott, thanks for the nice message. I'm glad somebody else addressed this issue. I am using codetriage.com to find other issues to work on. Looking forward to finding more opportunities to contribute to Node! I use it at work on a daily basis and I am so glad this technology exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants