test: refactoring test, reordering arguments #28343
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactors the test-buffer-inheritance.js test, switches the order of the arguments to be: 'actual', 'expected'
cjihrig
approved these changes
Jun 21, 2019
Trott
approved these changes
Jun 21, 2019
ZYSzys
approved these changes
Jun 22, 2019
ZYSzys
added
the
code-and-learn
BridgeAR
approved these changes
Jun 22, 2019
BridgeAR
added
the
author ready
trivikr
approved these changes
Jun 23, 2019
jasnell
approved these changes
Jun 23, 2019
|
Landed in 9451343 Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
ZYSzys
pushed a commit
to zys-contrib/node
that referenced
this pull request
Jun 26, 2019
Refactors the test-buffer-inheritance.js test, switches the order of the arguments to be: 'actual', 'expected' PR-URL: nodejs#28343 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 2, 2019
Refactors the test-buffer-inheritance.js test, switches the order of the arguments to be: 'actual', 'expected' PR-URL: #28343 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: James M Snell <[email protected]>
This was referenced Jul 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the test-buffer-inheritance.js test, switches the order of the
arguments to be: 'actual', 'expected'
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes