Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: resolve perf regression introduced by V8 7.3 #28842

Closed
wants to merge 3 commits into from
Closed

stream: resolve perf regression introduced by V8 7.3 #28842

wants to merge 3 commits into from

Commits on Jul 24, 2019

  1. stream: resolve perf regression introduced by V8 7.3 

    This commit contains two fixes:
1. use instanceof instead of Object.getPrototypeOf, as checking an
   object prototype with Object.getPrototypeOf is slower
   than an instanceof check.
2. avoid parseInt(undefined, 10) to get NaN as it regressed.

Fixes: nodejs#28586
    @mcollina
    mcollina committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    a6e108a View commit details
    Browse the repository at this point in the history

  2. Update lib/_stream_writable.js 

    Co-Authored-By: mscdex <[email protected]>
    @mcollina @mscdex
    mcollina and mscdex authored Jul 24, 2019
    Configuration menu
    Copy the full SHA
    0b015f8 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. Update lib/_stream_readable.js 

    Co-Authored-By: mscdex <[email protected]>
    @mcollina @mscdex
    mcollina and mscdex authored Jul 25, 2019
    Configuration menu
    Copy the full SHA
    14bc169 View commit details
    Browse the repository at this point in the history