tools: make nodedownload.py Python 3 compatible #29104
Conversation
nodejs-github-bot
added
the
build
cclauss
added
the
python
sam-github
force-pushed
the
python3-push-again
branch
from
02cea68
to
7046360
Compare
|
@cclauss I force-pushed your branch after I squashed the commits and rewrote the commit message to start with Also, kicked off a build. I support fast-tracking this if it is green in CI. |
No objections to fast tracking but as far as I can remember this file is only used to download ICU which the normal builds don't do (they use the ICU in |
|
./confugure.py imports this file and seems to use its functions in multiple places. https://github.com/nodejs/node/search?q=nodedownload&unscoped_q=nodedownload |
|
@nodejs/platform-windows Above CI failure seems irrelevant to this PR, which only changed some python syntax: https://ci.nodejs.org/job/node-test-binary-windows-2/2533/ It looks to be related to temp file cleanup, which I think has an open windows PR somewhere to fix it, but I haven't been able to find it. |
From memory, only on paths where ICU is downloaded (e.g. if |
|
If its tested and passed, seems OK to fast-track. If its not covered by the tests... then leaving it not-fasttracked won't make it better :-) Will a |
😁
With this PR and bash-4.2$ ./configure --download=all --with-intl=full-icu
<https://github.com/unicode-org/icu/releases/download/release-64-2/icu4c-64_2-src.tgz>
Fetch: . 23.5MB total, 23.5MB downloaded
Checking file integrity with md5:
md5: a3d18213beec454e3cdec9a3116d6b05 deps/icu4c-64_2-src.tgz
Extracting tarfile: deps/icu4c-64_2-src.tgz
INFO: Using floating patch "tools/icu/patches/64/source/common/putil.cpp" from "tools/icu"
INFO: Using floating patch "tools/icu/patches/64/source/i18n/dtptngen.cpp" from "tools/icu"
INFO: configure completed successfully
bash-4.2$So we should be no worse off than we are currently. |
|
OK, well fast-track or not, its all green in CI, 5 approvals, can be landed in 44 hours. |
addaleax
added
author ready
It landed. It's at #28858. Windows tmpdir cleanup issues have been worked on by @joaocgreis and, before that, @refack. |
sam-github
force-pushed
the
python3-push-again
branch
from
7046360
to
f057611
Compare
|
I rebased this onto master, and kicked off another ci |
|
None of the failures I see there seem to be related to this PR, and the following CI was green so this can land. The failure in Windows 2008 shows a ENOTEMPTY for a directory that seems empty. I want to investigate things like this, so thanks for mentioning me. The failures on other Windows versions show a problem with git fetching from the temp repo. Looking at Jenkins timestamps, the |
|
Thanks for the analysis @joaocgreis -- and for the work, @cclauss Landed in 8ae79c9 |
PR-URL: #29104 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #29104 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: nodejs#29104 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]> (cherry picked from commit 8ae79c9)
These changes make nodedownload.py compatible with both Python 2 and Python 3.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes