-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure: detect mipsel host #2971
Conversation
Detect mipsel before mips because mipsel has __mips__ flag as well.
What hardware are you testing on? |
On that testing machine i discovered detected host != --dest-cpu (mips != mipsel): |
I don't have mips hardware to reproduce this, but LGTM. I can merge this in a day or so unless anyone objects. |
cc @nodejs/build |
Detect mipsel before mips because mipsel has __mips__ flag as well. PR-URL: #2971 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
LGTM2. Landed in 5819d7a, thanks. |
Detect mipsel before mips because mipsel has __mips__ flag as well. PR-URL: #2971 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Johan Bergström <[email protected]>
landed in lts-v4.x-staging as f010cb5 |
Detect mipsel before mips because mipsel has
__mips__
flag as well.