Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: detect mipsel host #2971

Closed
wants to merge 1 commit into from
Closed

configure: detect mipsel host #2971

wants to merge 1 commit into from

Conversation

kapouer
Copy link
Contributor

@kapouer kapouer commented Sep 20, 2015

Detect mipsel before mips because mipsel has
__mips__ flag as well.

Detect mipsel before mips because mipsel has
__mips__ flag as well.
@brendanashworth brendanashworth added the build Issues and PRs related to build files or the CI. label Sep 20, 2015
@jbergstroem
Copy link
Member

What hardware are you testing on?

@kapouer
Copy link
Contributor Author

kapouer commented Sep 20, 2015

On that testing machine i discovered detected host != --dest-cpu (mips != mipsel):
https://db.debian.org/machines.cgi?host=eder
and on that build machine it fails too:
https://db.debian.org/machines.cgi?host=mipsel-aql-02

@kapouer
Copy link
Contributor Author

kapouer commented Sep 20, 2015

@jbergstroem
Copy link
Member

I don't have mips hardware to reproduce this, but LGTM. I can merge this in a day or so unless anyone objects.

@thefourtheye
Copy link
Contributor

cc @nodejs/build

bnoordhuis pushed a commit that referenced this pull request Sep 21, 2015
Detect mipsel before mips because mipsel has __mips__ flag as well.

PR-URL: #2971
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
@bnoordhuis
Copy link
Member

LGTM2. Landed in 5819d7a, thanks.

@bnoordhuis bnoordhuis closed this Sep 21, 2015
rvagg pushed a commit that referenced this pull request Sep 22, 2015
Detect mipsel before mips because mipsel has __mips__ flag as well.

PR-URL: #2971
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Johan Bergström <[email protected]>
@rvagg rvagg mentioned this pull request Sep 22, 2015
@MylesBorins
Copy link
Contributor

landed in lts-v4.x-staging as f010cb5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants