Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: fix file close error condition at respondWithFd #29884

Closed
wants to merge 1 commit into from
Closed

http2: fix file close error condition at respondWithFd #29884

wants to merge 1 commit into from

Commits on Oct 8, 2019

  1. http2: fix file close error condition at respondWithFd 

    Closing a FileHandle almost never fails, so it was hard to
notice before that `stream.emit(err)` would not emit an error
event due to the missing event name.

Destroying the stream with the error seems like the right thing
to do in that scenario.
    @addaleax
    addaleax committed Oct 8, 2019
    Configuration menu
    Copy the full SHA
    989ddfd View commit details
    Browse the repository at this point in the history