Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inspector: turn platform tasks that outlive Agent into no-ops #30031

Closed
wants to merge 3 commits into from

Commits on Oct 18, 2019

  1. inspector: turn platform tasks that outlive Agent into no-ops

    Turn tasks scheduled on the `v8::Isolate` or on the given platform
    into no-ops if the underlying `MainThreadInterface` has gone away
    before the task could be run (which would happen when the
    `Environment` instance and with it the `inspector::Agent` instance
    are destroyed).
    
    This addresses an issue that Electron has been having with
    inspector support, and generally just seems like the right thing
    to do, as we may not fully be in control of the relative timing
    of Environment teardown, platform tasksexecution, and the
    execution of `RequestInterrupt()` callbacks (although
    the former two always happen in the same order in our own code).
    addaleax committed Oct 18, 2019
    Configuration menu
    Copy the full SHA
    edf8070 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. Configuration menu
    Copy the full SHA
    521ce6a View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2019

  1. Configuration menu
    Copy the full SHA
    54a475b View commit details
    Browse the repository at this point in the history