fs: add bufferSize option to fs.opendir()
#30114
Conversation
Add an option that controls the size of the internal buffer. Fixes: nodejs#29941
nodejs-github-bot
added
c++
|
What a mob programming session 🙌🏻😀 |
|
300 people watched the process of this PR during @scriptconf Great job!!!!! |
|
Can approve that all tests were done |
|
Speaking of which: Needs tests. (Just forgot to |
Done, thanks!
I checked the box because I added benchmarks that measure the performance impact – I don’t think this is something that we could test for well without digging into internals. |
addaleax
added
the
semver-minor
Test passing non-numbers/negative numbers/zero/non-integers as |
And maybe one test for |
|
@Trott @richardlau I guess, yes – added tests for the error condition/that it works when using a positive integer value. |
Co-Authored-By: Richard Lau <[email protected]>
addaleax
added
the
author ready
|
Landed in b35181f 🎉 |
Add an option that controls the size of the internal buffer. Fixes: #29941 PR-URL: #30114 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Add an option that controls the size of the internal buffer. Fixes: #29941 PR-URL: #30114 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Notable changes:
* cli:
* Added a new flag (`--trace-uncaught`) that makes Node.js print the
stack trace at the time of throwing uncaught exceptions, rather than
at the creation of the `Error` object, if there is any. This is
disabled by default because it affects GC behavior.
#30025
* crypto
* Added `Hash.prototype.copy()` method. It returns a new `Hash` object
with its internal state cloned from the original one.
#29910
* dgram
* Added source-specific multicast support. This adds methods to
Datagram sockets to support RFC 4607
(https://tools.ietf.org/html/rfc4607) for IPv4 and IPv6.
#15735
* fs
* Added a `bufferSize` option to `fs.opendir()`. It allows to control
the number of entries that are buffered internally when reading from
the directory. #30114
* meta
* Added Chengzhong Wu (https://github.com/legendecas) to
collaborators. #30115
PR-URL: #30262
Notable changes:
* cli:
* Added a new flag (`--trace-uncaught`) that makes Node.js print the
stack trace at the time of throwing uncaught exceptions, rather than
at the creation of the `Error` object, if there is any. This is
disabled by default because it affects GC behavior.
#30025
* crypto
* Added `Hash.prototype.copy()` method. It returns a new `Hash` object
with its internal state cloned from the original one.
#29910
* dgram
* Added source-specific multicast support. This adds methods to
Datagram sockets to support RFC 4607
(https://tools.ietf.org/html/rfc4607) for IPv4 and IPv6.
#15735
* fs
* Added a `bufferSize` option to `fs.opendir()`. It allows to control
the number of entries that are buffered internally when reading from
the directory. #30114
* meta
* Added Chengzhong Wu (https://github.com/legendecas) to
collaborators. #30115
PR-URL: #30262
Add an option that controls the size of the internal buffer. Fixes: #29941 PR-URL: #30114 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Add an option that controls the size of the internal buffer. Fixes: #29941 PR-URL: #30114 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Add an option that controls the size of the internal
buffer.
Fixes: #29941
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes