test: bp fix for test-http-get-pipeline-problem.js #3013
Conversation
backport fix for test-http-get-pipeline-problem.js from master to 0.12.X. We've been seeing an intermittent failure in runs for zLinux with SLES 12. We confirmed that this fix resolves the issue so would like it in 0.12.X The original commit does not apply cleanly as the paths were changed, but the actual change is identical. The original commit was: nodejs@3ba4f71
|
@jasnell can you review. If it looks ok do I need to do anything extra after landing it to add it to the 0.12.8 release proposal ? |
|
LGTM! |
|
@jasnell is there something needed to get this into the next 12.X release ? |
|
Based on this from the commit message I would like it in 0.12.X
|
|
@rvagg @thealphanerd ... Not quite sure why this wasn't landed in one of the recent v0.12 updates. I can get it landed into staging today but wanted to check first in case there was a reason not to. |
|
No reason, just a broken workflow on my part that didn't properly take labels into account. I'm also not in a position to land this, without any access to, or understanding of zLinux. It has an LGTM so it could be landed by either @mhdawson or @jasnell. We'll be doing another v0.12 soon enough, there's a few minor things backed up for both it and 0.10. |
backport fix for test-http-get-pipeline-problem.js from master to 0.12.X. We've been seeing an intermittent failure in runs for zLinux with SLES 12. We confirmed that this fix resolves the issue so would like it in 0.12.X The original commit does not apply cleanly as the paths were changed, but the actual change is identical. The original commit was: 3ba4f71 PR-URL: #3013 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
Landed in v0.12-staging in 154098a |
backport fix for test-http-get-pipeline-problem.js from master to 0.12.X. We've been seeing an intermittent failure in runs for zLinux with SLES 12. We confirmed that this fix resolves the issue so would like it in 0.12.X The original commit does not apply cleanly as the paths were changed, but the actual change is identical. The original commit was: nodejs/node@3ba4f71 PR-URL: nodejs/node#3013 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: James M Snell <[email protected]>
backport fix for test-http-get-pipeline-problem.js from master
to 0.12.X. We've been seeing an intermittent failure
in runs for zLinux with SLES 12. We confirmed that this fix
resolves the issue so would like it in 0.12.X
The original commit does not apply cleanly as the paths were
changed, but the actual change is identical. The original commit was:
3ba4f71