-
Notifications
You must be signed in to change notification settings - Fork 29.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update http.md mention of socket #30155
Closed
Closed
Changes from 3 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
55e6663
doc: update http.md mention of socket
jessekoconnor 9eb3fac
docs: correct line spacing
jessekoconnor 8572afb
doc: update stream obj to duplex obj
jessekoconnor 863f6f4
doc: reword socket documentation wording
jessekoconnor d49e4dd
doc: Capitalize Duplex when referring to class
jessekoconnor 38171e9
doc: update request.keepAlive(duplex)
jessekoconnor 094d513
doc: update the events on Agent first
jessekoconnor e54b9e9
fix: update rest of events
jessekoconnor 2eec64c
fix: forgot one explanation
jessekoconnor 5b827a3
doc: suggest doc for methods
jessekoconnor fce5f9c
doc: address rest of relevant methods
jessekoconnor 7cf2e18
doc: suggestion from tniessen
jessekoconnor da4eec8
Update doc/api/http.md
jessekoconnor d08c71e
Update doc/api/http.md
jessekoconnor 352fce8
Update doc/api/http.md
jessekoconnor 916b271
Update doc/api/http.md
jessekoconnor 8f39b79
Update doc/api/http.md
jessekoconnor f1419f3
Update doc/api/http.md
jessekoconnor 92bbaec
Update doc/api/http.md
jessekoconnor b545157
doc: wording suggestion from tniessen
jessekoconnor 220cecb
doc: more tidying up
jessekoconnor 92fbdef
doc: even more tidying up
jessekoconnor 6809c26
fix: update further
jessekoconnor 14cf7aa
Update doc/api/http.md
jessekoconnor 1fc5adf
doc: Updates based on feedback from tniesson
jessekoconnor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two things:
an extendion the duplex object
→ soething likea subclass of `Duplex`
net.Socket
instanceThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Roger that, makes complete sense. I have updated this PR @addaleax to match both of your suggestions.