Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: destruct primordials in lib/internal/cluster/worker.js #30246

Closed
wants to merge 1 commit into from
Closed

cluster: destruct primordials in lib/internal/cluster/worker.js #30246

wants to merge 1 commit into from

Conversation

peze
Copy link
Contributor

@peze peze commented Nov 4, 2019 •
edited
Loading

Refs: nodejs/code-and-learn#97

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the cluster Issues and PRs related to the cluster subsystem. label Nov 4, 2019
@gireeshpunathil gireeshpunathil added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 4, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26308/

XadillaX
XadillaX approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@XadillaX XadillaX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is ok.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26321/

ZYSzys pushed a commit that referenced this pull request Nov 9, 2019
@peze @ZYSzys
cluster: destruct primordials in lib/internal/cluster/worker.js
0356746 
Refs: nodejs/code-and-learn#97

PR-URL: #30246
Refs: nodejs/code-and-learn#97
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@ZYSzys
Copy link
Member

ZYSzys commented Nov 9, 2019

Landed in 0356746.

Thanks for the contribution! 🎉

(If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.)

@ZYSzys ZYSzys closed this Nov 9, 2019
MylesBorins pushed a commit that referenced this pull request Nov 17, 2019
@peze @MylesBorins
cluster: destruct primordials in lib/internal/cluster/worker.js
6bf0e40 
Refs: nodejs/code-and-learn#97

PR-URL: #30246
Refs: nodejs/code-and-learn#97
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Nov 19, 2019
Merged
targos pushed a commit that referenced this pull request Dec 1, 2019
@peze @targos
cluster: destruct primordials in lib/internal/cluster/worker.js
5c72cc3 
Refs: nodejs/code-and-learn#97

PR-URL: #30246
Refs: nodejs/code-and-learn#97
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 9, 2019
Closed
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
@peze @MylesBorins
cluster: destruct primordials in lib/internal/cluster/worker.js
2938fe3 
Refs: nodejs/code-and-learn#97

PR-URL: #30246
Refs: nodejs/code-and-learn#97
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Khaidi Chu <[email protected]>
Reviewed-By: Yongsheng Zhang <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
@BethGriggs BethGriggs mentioned this pull request Dec 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZYSzys ZYSzys ZYSzys approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@XadillaX XadillaX XadillaX approved these changes

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
cluster Issues and PRs related to the cluster subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@peze @nodejs-github-bot @ZYSzys @addaleax @cjihrig @XadillaX @gengjiawen @gireeshpunathil @BridgeAR