Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: replace var with let #30396

Closed
wants to merge 1 commit into from
Closed

lib: replace var with let #30396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/internal/v8_prof_polyfill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ try {
const fd = fs.openSync(logFile, 'r');
const buf = Buffer.allocUnsafe(4096);
const dec = new (require('string_decoder').StringDecoder)('utf-8');
var line = '';
let line = '';

{
const message = versionCheck(peekline(), process.versions.v8);
Expand Down Expand Up @@ -125,7 +125,7 @@ function versionCheck(firstLine, expected) {
return 'Unable to read v8-version from log file.';
}
// Compare major, minor and build; ignore the patch and candidate fields.
for (var i = 0; i < 3; i++)
for (let i = 0; i < 3; i++)
if (curVer[i] !== firstLine[i + 1])
return 'Testing v8 version different from logging version';
}
Expand Down