Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: increase debugging information in subprocess test #30761

Merged
merged 0 commits into from
Dec 4, 2019
Merged

test: increase debugging information in subprocess test #30761

merged 0 commits into from
Dec 4, 2019
+0 −0

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 2, 2019

Refs: #25988 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 2, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27267/

@gireeshpunathil
Copy link
Member

thanks @Trott - I have been thinking of a debugging strategy around this without a way out. This looks like a great plan to me.

Only theory that can explain the current behavior (not the failure itself, but the missing debug info) is a race condition between child exit and its pipe flush, and this change is going to resolve that.

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 2, 2019
@Trott Trott closed this Dec 4, 2019
@Trott
Copy link
Member Author

Trott commented Dec 4, 2019

Landed in b299860

@Trott Trott merged commit b299860 into nodejs:master Dec 4, 2019
@Trott Trott deleted the subprocess branch December 4, 2019 13:37
@gireeshpunathil gireeshpunathil mentioned this pull request Dec 8, 2019
Closed
targos pushed a commit that referenced this pull request Dec 9, 2019
@Trott @targos
test: increase debugging information in subprocess test
54a266c 
Refs: #25988 (comment)

PR-URL: #30761
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
Merged
targos pushed a commit that referenced this pull request Jan 13, 2020
@Trott @targos
test: increase debugging information in subprocess test
193a020 
Refs: #25988 (comment)

PR-URL: #30761
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@Trott @BethGriggs
test: increase debugging information in subprocess test
d3004aa 
Refs: #25988 (comment)

PR-URL: #30761
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
This was referenced Apr 13, 2021
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Sep 18, 2021
Open
Open
Open
@Dmarch28 Dmarch28 mentioned this pull request May 13, 2022
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request May 13, 2022
Open
@137717unity 137717unity mentioned this pull request May 13, 2022
Open
@baby636 baby636 mentioned this pull request May 13, 2022
Open
@kissofire kissofire mentioned this pull request May 13, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 13, 2022
Open
@ron-a20 ron-a20 mentioned this pull request May 13, 2022
Open
@molllyn1 molllyn1 mentioned this pull request May 14, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
@aliceUnhinged613 aliceUnhinged613 mentioned this pull request Nov 25, 2023
Open
@wedataintelligence wedataintelligence mentioned this pull request Nov 28, 2023
Open
@baby636 baby636 mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Trott @nodejs-github-bot @gireeshpunathil @addaleax @lpinca @cjihrig