v13.3.0 proposal

.eslintrc.js

@@ -118,12 +118,14 @@ module.exports = {
     'no-class-assign': 'error',
     'no-confusing-arrow': 'error',
     'no-const-assign': 'error',
+    'no-constructor-return': 'error',
     'no-control-regex': 'error',
     'no-debugger': 'error',
     'no-delete-var': 'error',
     'no-dupe-args': 'error',
     'no-dupe-class-members': 'error',
     'no-dupe-keys': 'error',
+    'no-dupe-else-if': 'error',
     'no-duplicate-case': 'error',
     'no-duplicate-imports': 'error',
     'no-empty-character-class': 'error',
@@ -247,6 +249,7 @@ module.exports = {
     'no-return-await': 'error',
     'no-self-assign': 'error',
     'no-self-compare': 'error',
+    'no-setter-return': 'error',
     'no-shadow-restricted-names': 'error',
     'no-tabs': 'error',
     'no-template-curly-in-string': 'error',
@@ -279,6 +282,10 @@ module.exports = {
     'one-var': ['error', { initialized: 'never' }],
     'one-var-declaration-per-line': 'error',
     'operator-linebreak': ['error', 'after'],
+    'padding-line-between-statements': [
+      'error',
+      { blankLine: 'always', prev: 'function', next: 'function' },
+    ],
     'prefer-const': ['error', { ignoreReadBeforeAssign: true }],
     'quotes': ['error', 'single', { avoidEscape: true }],
     'quote-props': ['error', 'consistent'],

AUTHORS

@@ -2866,5 +2866,84 @@ akitsu-sanae <[email protected]>
 Minuk Park <[email protected]>
 Jim Schlight <[email protected]>
 Theotime Poisseau <[email protected]>
+Alex Zherdev <[email protected]>
+dev-313 <[email protected]>
+Michael Perrotte <[email protected]>
+Alexandre Ferrando <[email protected]>
+Loris Zinsou <[email protected]>
+Jizu Sun <[email protected]>
+AshCripps <[email protected]>
+garygsc <[email protected]>
+Patrick Housley <[email protected]>
+Artem Maksimov <[email protected]>
+Nolik <[email protected]>
+palmires <[email protected]>
+Vadim Gorbachev <[email protected]>
+galina.prokofeva <[email protected]>
+Nadya <[email protected]>
+PerfectPan <[email protected]>
+peze <[email protected]>
+Vladislav Botvin <[email protected]>
+Ilia Safronov <[email protected]>
+Dmitriy Kikinskiy <[email protected]>
+telenord <nordtelecom.yandex.ru>
+alexahdp <[email protected]>
+Daniil Pletnev <[email protected]>
+Grigoriy Levanov <[email protected]>
+Simon Schick <[email protected]>
+Albert Wang <[email protected]>
+Kenza Houmani <[email protected]>
+mkdorff <[email protected]>
+xefimx <[email protected]>
+garygsc <[email protected]>
+Susana Ferreira <[email protected]>
+Xavier Redondo <[email protected]>
+Duncan Healy <[email protected]>
+SoulMonk <[email protected]>
+Kerry Mahne <[email protected]>
+nathias <[email protected]>
+Nikolay Krashnikov <[email protected]>
+daern91 <[email protected]>
+JL Phillips <[email protected]>
+Jure Stepisnik <[email protected]>
+Raoul Jaeckel <[email protected]>
+Kyriakos Markakis <[email protected]>
+Guilherme Goncalves <[email protected]>
+Jesse O'Connor <[email protected]>
+VinceOPS <[email protected]>
+David OLIVIER <[email protected]>
+Maria Stogova <[email protected]>
+Taylor Gagne <[email protected]>
+Kirlat <[email protected]>
+Lucas Recknagel <[email protected]>
+Oliver Belaifa <[email protected]>
+guzhizhou <[email protected]>
+Paolo Ceschi Berrini <[email protected]>
+Jing Lin <[email protected]>
+poutch <[email protected]>
+Tembrechts <[email protected]>
+Jon Church <[email protected]>
+Àlvar Pérez <[email protected]>
+Daniel Schuech <[email protected]>
+Dimitris Ktistakis <[email protected]>
+Dries Stelten <[email protected]>
+Vladimir Adamic <[email protected]>
+Shubham Chaturvedi <[email protected]>
+Jamar Torres <[email protected]>
+Luis Camargo <[email protected]>
+Herrmann, Rene R. (656) <[email protected]>
+Semir Ajruli <[email protected]>
+matijagaspar <[email protected]>
+Aldo Ambrosioni <[email protected]>
+Nazar Malyy <[email protected]>
+Dennis Saenger <[email protected]>
+ryan jarvinen <[email protected]>
+Maria Emmanouil <[email protected]>
+Tijl Claessens <[email protected]>
+EmaSuriano <[email protected]>
+Chris Oyler <[email protected]>
+Jesper Ek <[email protected]>
+Luciano <[email protected]>
+jens-cappelle <[email protected]>
 
 # Generated by tools/update-authors.js

BUILDING.md

@@ -116,7 +116,7 @@ platforms. This is true regardless of entries in the table below.
 | macOS            | x64              | >= 10.11                        | Tier 1       |                                   |
 | SmartOS          | x64              | >= 18                           | Tier 2       |                                   |
 | AIX              | ppc64be >=power7 | >= 7.2 TL02                     | Tier 2       |                                   |
-| FreeBSD          | x64              | >= 11                           | Experimental | Downgraded as of Node.js 12       |
+| FreeBSD          | x64              | >= 11                           | Experimental | Downgraded as of Node.js 12  <sup>[7](#fn7)</sup>     |
 
 <em id="fn1">1</em>: GCC 6 is not provided on the base platform, users will
   need the
@@ -150,6 +150,10 @@ are provided. However, tests in our infrastructure only run on WoW64.
 Furthermore, compiling on x86 Windows is currently considered Experimental and
 may not be possible.
 
+<em id="fn7">7</em>: The default FreeBSD 12.0 compiler is Clang 6.0.1, but
+FreeBSD 12.1 upgrades to 8.0.1. Other Clang/LLVM versions are provided
+via the system's package manager, including Clang 9.0.
+
 ### Supported toolchains
 
 Depending on the host platform, the selection of toolchains may vary.
@@ -214,9 +218,10 @@ Supported platforms and toolchains change with each major version of Node.js.
 This document is only valid for the current major version of Node.js.
 Consult previous versions of this document for older versions of Node.js:
 
+* [Node.js 13](https://github.com/nodejs/node/blob/v13.x/BUILDING.md)
+* [Node.js 12](https://github.com/nodejs/node/blob/v12.x/BUILDING.md)
 * [Node.js 10](https://github.com/nodejs/node/blob/v10.x/BUILDING.md)
 * [Node.js 8](https://github.com/nodejs/node/blob/v8.x/BUILDING.md)
-* [Node.js 6](https://github.com/nodejs/node/blob/v6.x/BUILDING.md)
 
 ## Building Node.js on supported platforms
 

CHANGELOG.md

@@ -30,7 +30,8 @@ release.
 </tr>
 <tr>
     <td valign="top">
-<b><a href="doc/changelogs/CHANGELOG_V13.md#13.2.0">13.2.0</a></b><br/>
+<b><a href="doc/changelogs/CHANGELOG_V13.md#13.3.0">13.3.0</a></b><br/>
+<a href="doc/changelogs/CHANGELOG_V13.md#13.2.0">13.2.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.1.0">13.1.0</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.0.1">13.0.1</a><br/>
 <a href="doc/changelogs/CHANGELOG_V13.md#13.0.0">13.0.0</a><br/>

COLLABORATOR_GUIDE.md

@@ -187,7 +187,9 @@ Do not land any pull requests without passing (green or yellow) CI runs. If
 there are CI failures unrelated to the change in the pull request, try "Resume
 Build". It is in the left navigation of the relevant `node-test-pull-request`
 job. It will preserve all the green results from the current job but re-run
-everything else.
+everything else. Start a fresh CI if more than seven days have elapsed since
+the original failing CI as the compiled binaries for the Windows and ARM
+platforms are only kept for seven days.
 
 Some of the CI Jobs may require `GIT_REMOTE_REF` which is the remote portion
 of Git refspec. To specify the branch this way `refs/heads/BRANCH` is used

CPP_STYLE_GUIDE.md

@@ -1,5 +1,8 @@
 # C++ Style Guide
 
+See also the [C++ codebase README](src/README.md) for C++ idioms in the Node.js
+codebase not related to stylistic issues.
+
 ## Table of Contents
 
 * [Guides and References](#guides-and-references)

LICENSE

@@ -1503,3 +1503,28 @@ The externally maintained libraries used by Node.js are:
     ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR
     IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
   """
+
+- uvwasi, located at deps/uvwasi, is licensed as follows:
+  """
+    MIT License
+
+    Copyright (c) 2019 Colin Ihrig and Contributors
+
+    Permission is hereby granted, free of charge, to any person obtaining a copy
+    of this software and associated documentation files (the "Software"), to deal
+    in the Software without restriction, including without limitation the rights
+    to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+    copies of the Software, and to permit persons to whom the Software is
+    furnished to do so, subject to the following conditions:
+
+    The above copyright notice and this permission notice shall be included in all
+    copies or substantial portions of the Software.
+
+    THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+    IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+    FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+    AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+    LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+    OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+    SOFTWARE.
+  """

Makefile

@@ -489,6 +489,7 @@ test-all-valgrind: test-build
 test-all-suites: | clear-stalled test-build bench-addons-build doc-only ## Run all test suites.
 	$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/*
 
+# CI_* variables should be kept synchronized with the ones in vcbuild.bat
 CI_NATIVE_SUITES ?= addons js-native-api node-api
 CI_JS_SUITES ?= default
 ifeq ($(node_use_openssl), false)
@@ -745,7 +746,7 @@ $(LINK_DATA): $(wildcard lib/*.js) tools/doc/apilinks.js
 	$(call available-node, $(gen-apilink))
 
 out/doc/api/%.json out/doc/api/%.html: doc/api/%.md tools/doc/generate.js \
-	tools/doc/html.js tools/doc/json.js tools/doc/apilinks.js | $(LINK_DATA)
+	tools/doc/markdown.js tools/doc/html.js tools/doc/json.js tools/doc/apilinks.js | $(LINK_DATA)
 	$(call available-node, $(gen-api))
 
 out/doc/api/all.html: $(apidocs_html) tools/doc/allhtml.js \

README.md

@@ -49,7 +49,7 @@ Looking for help? Check out the
   each October.
 * **LTS**: Releases that receive Long-term Support, with a focus on stability
   and security. Every even-numbered major version will become an LTS release.
-  LTS releases receive 18 months of _Active LTS_ support and a further 12 months
+  LTS releases receive 12 months of _Active LTS_ support and a further 18 months
   of _Maintenance_. LTS release lines have alphabetically-ordered codenames,
   beginning with v4 Argon. There are no breaking changes or feature additions,
   except in some special circumstances.

benchmark/process/next-tick-breadth-args.js

@@ -13,16 +13,19 @@ function main({ n }) {
     if (j === n)
       bench.end(n);
   }
+
   function cb2(arg1, arg2) {
     j++;
     if (j === n)
       bench.end(n);
   }
+
   function cb3(arg1, arg2, arg3) {
     j++;
     if (j === n)
       bench.end(n);
   }
+
   function cb4(arg1, arg2, arg3, arg4) {
     j++;
     if (j === n)

benchmark/process/next-tick-depth-args.js

@@ -20,6 +20,7 @@ function main({ n }) {
     } else
       bench.end(n);
   }
+
   function cb3(arg1, arg2, arg3) {
     if (--counter) {
       if (counter % 4 === 0)
@@ -33,6 +34,7 @@ function main({ n }) {
     } else
       bench.end(n);
   }
+
   function cb2(arg1, arg2) {
     if (--counter) {
       if (counter % 4 === 0)
@@ -46,6 +48,7 @@ function main({ n }) {
     } else
       bench.end(n);
   }
+
   function cb1(arg1) {
     if (--counter) {
       if (counter % 4 === 0)

benchmark/streams/writable-manywrites.js

@@ -4,14 +4,19 @@ const common = require('../common');
 const Writable = require('stream').Writable;
 
 const bench = common.createBenchmark(main, {
-  n: [2e6]
+  n: [2e6],
+  sync: ['yes', 'no']
 });
 
-function main({ n }) {
+function main({ n, sync }) {
   const b = Buffer.allocUnsafe(1024);
   const s = new Writable();
+  sync = sync === 'yes';
   s._write = function(chunk, encoding, cb) {
-    cb();
+    if (sync)
+      cb();
+    else
+      process.nextTick(cb);
   };
 
   bench.start();

benchmark/timers/set-immediate-breadth-args.js

@@ -12,7 +12,9 @@ function main({ n }) {
   });
 
   function cb1(arg1) {}
+
   function cb2(arg1, arg2) {}
+
   function cb3(arg1, arg2, arg3) {}
 
   bench.start();

benchmark/timers/set-immediate-depth-args.js

@@ -21,6 +21,7 @@ function main({ n }) {
         setImmediate(cb1, n);
     }
   }
+
   function cb2(n, arg2) {
     if (--n) {
       if (n % 3 === 0)
@@ -31,6 +32,7 @@ function main({ n }) {
         setImmediate(cb1, n);
     }
   }
+
   function cb1(n) {
     if (--n) {
       if (n % 3 === 0)

benchmark/timers/timers-breadth-args.js

@@ -12,16 +12,19 @@ function main({ n }) {
     if (j === n)
       bench.end(n);
   }
+
   function cb2(arg1, arg2) {
     j++;
     if (j === n)
       bench.end(n);
   }
+
   function cb3(arg1, arg2, arg3) {
     j++;
     if (j === n)
       bench.end(n);
   }
+
   function cb4(arg1, arg2, arg3, arg4) {
     j++;
     if (j === n)

benchmark/timers/timers-timeout-nexttick.js

@@ -19,9 +19,11 @@ function main({ n }) {
   function cb() {
     process.nextTick(counter);
   }
+
   function cb2() {
     process.nextTick(counter);
   }
+
   function counter() {
     count++;
     if (count === n)

benchmark/timers/timers-timeout-pooled.js

@@ -20,6 +20,7 @@ function main({ n }) {
     if (count === n)
       bench.end(n);
   }
+
   function cb2() {
     count++;
     if (count === n)

benchmark/timers/timers-timeout-unpooled.js

@@ -20,6 +20,7 @@ function main({ n }) {
     if (count === n)
       bench.end(n);
   }
+
   function cb2() {
     count++;
     if (count === n)

common.gypi

@@ -39,7 +39,7 @@
 
     # Reset this number to 0 on major V8 upgrades.
     # Increment by one for each non-official patch applied to deps/v8.
-    'v8_embedder_string': '-node.20',
+    'v8_embedder_string': '-node.23',
 
     ##### V8 defaults for Node.js #####
 

configure

@@ -20,7 +20,7 @@ del _
 import sys
 from distutils.spawn import find_executable
 
-print('Node configure: Found Python {0}.{1}.{2}...'.format(*sys.version_info))
+print('Node.js configure: Found Python {0}.{1}.{2}...'.format(*sys.version_info))
 acceptable_pythons = ((3, 8), (3, 7), (3, 6), (3, 5), (2, 7))
 if sys.version_info[:2] in acceptable_pythons:
   import configure