Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove common.busyLoop() #30787

Merged
merged 2 commits into from
Dec 7, 2019
Merged

test: remove common.busyLoop() #30787

merged 2 commits into from
Dec 7, 2019

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 4, 2019

This PR builds on #30784 and #30783.

This commit replaces common.busyLoop() with sleep().

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Dec 4, 2019
@cjihrig cjihrig changed the title Busyloop test: remove common.busyLoop() Dec 4, 2019
@cjihrig cjihrig mentioned this pull request Dec 4, 2019
4 tasks
@addaleax addaleax added the blocked PRs that are blocked by other issues or PRs. label Dec 4, 2019
@cjihrig cjihrig removed the blocked PRs that are blocked by other issues or PRs. label Dec 6, 2019
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 7, 2019

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2019
PR-URL: nodejs#30787
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
This commit replaces common.busyLoop() with sleep().

PR-URL: nodejs#30787
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@cjihrig
Copy link
Contributor Author

cjihrig commented Dec 7, 2019

Landed in 4ec02d5...aa363c4.

@cjihrig cjihrig deleted the busyloop branch December 7, 2019 03:04
targos pushed a commit that referenced this pull request Dec 9, 2019
PR-URL: #30787
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this pull request Dec 9, 2019
This commit replaces common.busyLoop() with sleep().

PR-URL: #30787
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
targos pushed a commit that referenced this pull request Jan 14, 2020
PR-URL: #30787
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2020
This commit replaces common.busyLoop() with sleep().

PR-URL: #30787
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
PR-URL: #30787
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
This commit replaces common.busyLoop() with sleep().

PR-URL: #30787
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Gus Caplan <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
benjamingr added a commit to benjamingr/io.js that referenced this pull request Jan 27, 2022
This change makes the eventloopdelay test less flakey on some platforms
by replacing a blocking-wait with a busy-wait which means the eventloop
will always be positive increase.

This is a partial revert of nodejs#30787 that returns the test to the state it
had originally.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants