Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: remove duplicate _undestroy #30833

Closed
wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Dec 7, 2019

initSocketHandle will call _undestroy.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

initSocketHandle will call _undestroy.
@nodejs-github-bot nodejs-github-bot added the net Issues and PRs related to the net subsystem. label Dec 7, 2019
@ronag
Copy link
Member Author

ronag commented Dec 7, 2019

@Trott: I'm confused by this travis failure. What failed?

@Trott
Copy link
Member

Trott commented Dec 7, 2019

@Trott: I'm confused by this travis failure. What failed?

You mean the JS tests in particular? I don't know either. Let's kick off a Jenkins CI and see what that looks like....

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Dec 7, 2019

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 8, 2019
danbev pushed a commit that referenced this pull request Dec 11, 2019
initSocketHandle will call _undestroy.

PR-URL: #30833
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@danbev
Copy link
Contributor

danbev commented Dec 11, 2019

Landed in 855ca73.

@danbev danbev closed this Dec 11, 2019
targos pushed a commit that referenced this pull request Dec 11, 2019
initSocketHandle will call _undestroy.

PR-URL: #30833
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 13, 2019
targos pushed a commit that referenced this pull request Jan 14, 2020
initSocketHandle will call _undestroy.

PR-URL: #30833
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
initSocketHandle will call _undestroy.

PR-URL: #30833
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. net Issues and PRs related to the net subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants