Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: certain response headers do not allow multiple instances #3090

Closed
wants to merge 5 commits into from
Closed

http: certain response headers do not allow multiple instances #3090

wants to merge 5 commits into from

Commits on Oct 6, 2015

  1. http: add callback is function check 

    We were checking that the callback existed, but not
checking that it was a function
    @jasnell
    jasnell committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    3827ad5 View commit details
    Browse the repository at this point in the history

  2. http: do not allow multiple instances of certain response headers 

    Response headers such as ETag and Last-Modified do not permit
multiple instances, and therefore the comma-separated syntax is
not allowed.
    @jasnell
    jasnell committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    4eed242 View commit details
    Browse the repository at this point in the history

  3. test: cleanup nits in test-http-response-multiheaders.js 

    Address the feedback from @thefourtheye
    @jasnell
    jasnell committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    5333b54 View commit details
    Browse the repository at this point in the history

  4. http: if callback is truthy but not a function, throw 

    in `setTimeout`, if callback is truthy but not a function,
throw a TypeError per @bnoordhuis' suggestion
    @jasnell
    jasnell committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    65047e0 View commit details
    Browse the repository at this point in the history

  5. test: expand test-http-response-multiheaders test 

    Include writeHead in the test per @bnoordhuis' suggestion
    @jasnell
    jasnell committed Oct 6, 2015
    Configuration menu
    Copy the full SHA
    4652af7 View commit details
    Browse the repository at this point in the history