Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add missing test flags #30971

Closed
wants to merge 1 commit into from
Closed

test: add missing test flags #30971

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Dec 15, 2019

test-wasi-start-validation.js should require the --experimental-wasi-unstable-preview0 flag in order to run. However, due to a recent regression, that hasn't been enforced. #30963 fixes the regression and will cause this test to start (correctly) failing. This commit adds the missing flag.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

test-wasi-start-validation.js should require the
--experimental-wasi-unstable-preview0 flag in order to run.
However, due to a recent regression, that hasn't been enforced.
nodejs#30963 fixes the regression
and will cause this test to start (correctly) failing. This
commit adds the missing flag.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 15, 2019
@Trott
Copy link
Member

Trott commented Dec 15, 2019

Fast-track to unblock #30963?

@Trott
Copy link
Member

Trott commented Dec 15, 2019

Or another suggestion: Close this PR and add this commit as a first commit in #30963.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 15, 2019
@nodejs-github-bot
Copy link
Collaborator

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 15, 2019
@Trott
Copy link
Member

Trott commented Dec 15, 2019

Landed in 2097a6f

@Trott Trott closed this Dec 15, 2019
Trott pushed a commit that referenced this pull request Dec 15, 2019
test-wasi-start-validation.js should require the
--experimental-wasi-unstable-preview0 flag in order to run.
However, due to a recent regression, that hasn't been enforced.
#30963 fixes the regression
and will cause this test to start (correctly) failing. This
commit adds the missing flag.

PR-URL: #30971
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@cjihrig cjihrig deleted the test-fix branch December 15, 2019 14:39
MylesBorins pushed a commit that referenced this pull request Dec 17, 2019
test-wasi-start-validation.js should require the
--experimental-wasi-unstable-preview0 flag in order to run.
However, due to a recent regression, that hasn't been enforced.
#30963 fixes the regression
and will cause this test to start (correctly) failing. This
commit adds the missing flag.

PR-URL: #30971
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Dec 17, 2019
targos pushed a commit that referenced this pull request Jan 14, 2020
test-wasi-start-validation.js should require the
--experimental-wasi-unstable-preview0 flag in order to run.
However, due to a recent regression, that hasn't been enforced.
#30963 fixes the regression
and will cause this test to start (correctly) failing. This
commit adds the missing flag.

PR-URL: #30971
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
test-wasi-start-validation.js should require the
--experimental-wasi-unstable-preview0 flag in order to run.
However, due to a recent regression, that hasn't been enforced.
#30963 fixes the regression
and will cause this test to start (correctly) failing. This
commit adds the missing flag.

PR-URL: #30971
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants