Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stream: simplify isBuf #31067

Closed
wants to merge 1 commit into from
Closed

stream: simplify isBuf #31067

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Dec 23, 2019

simplify chunk encoding handling

 streams/writable-manywrites.js writev='no' sync='no' n=2000000                  -0.41 %       ±2.03% ±2.69% ±3.47%
 streams/writable-manywrites.js writev='no' sync='yes' n=2000000         ***      6.00 %       ±2.58% ±3.46% ±4.58%
 streams/writable-manywrites.js writev='yes' sync='no' n=2000000                  2.18 %       ±2.43% ±3.22% ±4.15%
 streams/writable-manywrites.js writev='yes' sync='yes' n=2000000                -1.24 %       ±3.16% ±4.25% ±5.60%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Dec 23, 2019
@ronag ronag force-pushed the writable-isbuf branch 2 times, most recently from 51b0309 to f2eb4b4 Compare December 23, 2019 13:42
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 24, 2019
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/27903/

lundibundi
lundibundi approved these changes Dec 24, 2019
View reviewed changes
lib/_stream_writable.js Show resolved Hide resolved
BridgeAR pushed a commit that referenced this pull request Dec 25, 2019
@ronag @BridgeAR
stream: simplify isBuf
cd6b00d 
PR-URL: #31067
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@BridgeAR
Copy link
Member

Landed in cd6b00d 🎉

@BridgeAR BridgeAR closed this Dec 25, 2019
BridgeAR pushed a commit that referenced this pull request Jan 3, 2020
@ronag @BridgeAR
stream: simplify isBuf
1463214 
PR-URL: #31067
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@BridgeAR BridgeAR mentioned this pull request Jan 7, 2020
Merged
targos pushed a commit that referenced this pull request Jan 14, 2020
@ronag @targos
stream: simplify isBuf
4e55e85 
PR-URL: #31067
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
targos pushed a commit that referenced this pull request Jan 14, 2020
@ronag @targos
stream: simplify isBuf
a0f5207 
PR-URL: #31067
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@targos targos mentioned this pull request Jan 15, 2020
Closed
BethGriggs pushed a commit that referenced this pull request Feb 6, 2020
@ronag @BethGriggs
stream: simplify isBuf
b12b930 
PR-URL: #31067
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Denys Otrishko <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Feb 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@lundibundi lundibundi lundibundi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ronag @nodejs-github-bot @BridgeAR @addaleax @lundibundi