v10.18.1 proposal #31248
Merged
v10.18.1 proposal #31248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #28071 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Refael Ackermann (רפאל פלחי) <[email protected]>
The devtoolset doesn't use or set the CXX, etc, env vars, so ignore them if not present. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
https://ci.nodejs.org/job/node-test-commit-v8-linux/configure echoes python code into tools and runs it. Move these scripts into tools for better maintainability. Once this lands and is back-ported into LTS branches a bunch of shell code can be deleted from the job. PR-URL: #28458 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Rich Trott <[email protected]>
Backport-PR-URL: #30338 PR-URL: #24641 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
Refs: #30211 Refs: #30356 PR-URL: #30479 Reviewed-By: Steven R Loomis <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
Original commit message:
[Intl] Fix output of hour:'2-digit', hour12: true
Bug: chromium:527926
Change-Id: I783ba59c6e4b117163e058032fb04283e1f43c46
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529260
Reviewed-by: Sathya Gunasekaran <[email protected]>
Commit-Queue: Frank Tang <[email protected]>
Cr-Commit-Position: refs/heads/master@{#60379}
Refs: v8/v8@fb63e5c
Fixes: #30369
Backport-PR-URL: #30372
napi_get_last_error returns incorrect napi_status. Backport-PR-URL: #30532 PR-URL: #28702 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Don't exit vcbuild with error code 0 when cctest fails. Backport-PR-URL: #30726 PR-URL: #30724 Refs: nodejs/build#1996 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]>
PR-URL: #25868 Refs: #25867 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gus Caplan <[email protected]>
Fixes: #29764 PR-URL: #29780 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Anto Aravinth <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
See: nodejs/readable-stream#420 PR-URL: #30140 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Beth Griggs <[email protected]>
The ability to pause input processing was added in 8a4a193 but introduced a session memory accounting mismatch leading to potential NGHTTP2_ENHANCE_YOUR_CALM errors. After pausing (https://github.com/nodejs/node/blob/f36331c1bfa4c4c202346b05dc3bd672f653e4df/src/node_http2.cc#L871), the early return on line 873 skips the DecrementCurrentSessionMemory(stream_buf_.len) call below (line 878). When we later finished processing the input chunk (https://github.com/nodejs/node/blob/f36331c1bfa4c4c202346b05dc3bd672f653e4df/src/node_http2.cc#L1858), we were calling DecrementCurrentSessionMemory(stream_buf_offset_) [line 1875] which was a no-op since we just set stream_buf_offset_ to 0 [line 1873]. The correct amount to decrement by is still stream_buf_.len, since that's the amount we skipped previously (line 878). Fixes: #29223 Refs: 164ac5b PR-URL: #30684 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Denys Otrishko <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]>
Allow use of <code> in header elements without styling side effects. We can add styling later if desired. The goal here is to allow code to be set off in markdown without needing to escape characters and do lint exceptions for terms. This is probably a win in terms of accessibility too although it would be moreso if we had some visual differentiation for <code> inside of headers. As mentioned above, that can always be added at a later time. Backport-PR-URL: #31109 PR-URL: #31086 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This will allow us to lint for use of `hostname` in prose without flagging `hostname` in code within headers. This also allows us to remove backslash escaping for `[` and `]` inside of header code, which makes the bare markdown more readable. Backport-PR-URL: #31109 PR-URL: #31086 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
MAX_HWM was added in 9208c89 where the highwatermark was changed to always increase in steps of highest power of 2 to prevent increasing hwm excessivly in tiny amounts. Why a limit was added on the highwatermark is unclear but breaks existing usage where a larger read size is used. The invariant for read(n) is that a buffer of size n is always returned. Considering a maximum ceiling on the buffer size breaks this invariant. This PR significantly increases the limit to make it less likely to break the previous invariant and also documents the limit. Fixes: #29933 PR-URL: #29938 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
nodejs-github-bot
added
lib / src
Closed
BethGriggs
added a commit
that referenced
this pull request
Jan 7, 2020
BethGriggs
force-pushed
the
v10.18.1-proposal
branch
from
8dd6062
to
b189fd4
Compare
richardlau
approved these changes
Jan 7, 2020
|
Is the timezone data update considered notable? |
|
Should #28840 maybe be included? Or is that actually semver-minor? |
|
CITGM v10.x - https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2199/console Still waiting on some CI runs...I'll update the dates and aim to push this out tomorrow morning. |
|
@BethGriggs #30537 will still land somewhere, right? It's also semver-minor. |
gengjiawen
approved these changes
Jan 8, 2020
patilharshal16
approved these changes
Jan 8, 2020
BethGriggs
force-pushed
the
v10.18.1-proposal
branch
from
b189fd4
to
56a206e
Compare
BethGriggs
force-pushed
the
v10.18.1-proposal
branch
from
56a206e
to
76b7cb4
Compare
|
@gabrielschulhof, that PR will be merged and go out with the next minor release, which is currently due at the end of January - nodejs/Release#504 |
|
Still working on getting the last few platforms CITGM results (nodejs/citgm#779) |
BethGriggs
force-pushed
the
v10.18.1-proposal
branch
from
76b7cb4
to
8d5e286
Compare
BethGriggs
added a commit
to BethGriggs/nodejs.org
that referenced
this pull request
Jan 9, 2020
BethGriggs
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Jan 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Previously #30796, I'd rather the branches match)
2020-01-07, Version 10.18.1 'Dubnium' (LTS), @BethGriggs
Notable changes
Commits
a80c59130e] - build: fix configure script to work with Apple Clang 11 (Saagar Jha) #2807168b2b5cc51] - build,win: propagate error codes in vcbuild (João Reis) #307243e0709cf5e] - deps: V8: backport fb63e5cf55e9 (Michaël Zasso)25b8fbda35] - doc: allow <code> in header elements (Rich Trott) #31086a1b095dd46] - doc,dns: use code markup/markdown in headers (Rich Trott) #310868f3b8ca515] - http2: fix session memory accounting after pausing (Michael Lehenbauer) #3068420f64a96de] - http2: use the latest settings (ZYSzys) #2978081c31005fd] - lib: fix comment nits in bootstrap\loaders.js (Vse Mozhet Byt) #2464188e8b7cf83] - n-api: correct bug in napi_get_last_error (Octavian Soldea) #2870277e0318849] - stream: increase MAX_HWM (Robert Nagy) #29938894aaa2040] - stream: extract Readable.from in its own file (Matteo Collina) #301407e941eb17d] - test: do not fail SLOW tests if they are not slow (Yang Guo) #258680f3ae77aaf] - tools: update tzdata to 2019c (Myles Borins) #304794ae8d204cb] - tools: move python code out of jenkins shell (Sam Roberts) #284584879b80d87] - tools: fix v8 testing with devtoolset on ppcle (Sam Roberts) #28458