Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,src: switch Buffer::kMaxLength to size_t #31406

Closed
wants to merge 2 commits into from
Closed

lib,src: switch Buffer::kMaxLength to size_t #31406

wants to merge 2 commits into from

Commits on Jan 18, 2020

  1. lib,src: switch Buffer::kMaxLength to size_t 

    Change the type of `Buffer::kMaxLength` to size_t because upcoming
changes in V8 will allow typed arrays > 2 GB on 64 bits platforms.

Not all platforms handle file reads and writes > 2 GB though so keep
enforcing the 2 GB typed array limit for I/O operations.

Fixes: nodejs#31399
Refs: libuv/libuv#1501
    @bnoordhuis
    bnoordhuis committed Jan 18, 2020
    Configuration menu
    Copy the full SHA
    967aa51 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2020

  1. fixup! use Number::New()

    @bnoordhuis
    bnoordhuis committed Jan 20, 2020
    Configuration menu
    Copy the full SHA
    df92967 View commit details
    Browse the repository at this point in the history