crypto: enable FIPS only when configured with it #3153
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not rely on `OPENSSL_FIPS` in `node_crypto.cc` when building with shared FIPS-enabled OpenSSL library. Enable FIPS in core only when configured with `--openssl-fips`. Fix: nodejs#3077
|
LGTM |
|
Thanks, @bnoordhuis. I'm going to skip CI run, because we are not testing FIPS mode anyway. |
|
Landed in 9bd26e7 |
indutny
added a commit
that referenced
this pull request
Oct 1, 2015
Do not rely on `OPENSSL_FIPS` in `node_crypto.cc` when building with shared FIPS-enabled OpenSSL library. Enable FIPS in core only when configured with `--openssl-fips`. Fix: #3077 PR-URL: #3153 Reviewed-By: Ben Noordhuis <[email protected]>
@indutny don't discount weird side-effects that you can't predict, like Windows oddities with .gyp files or compiler differences. CI runs are cheap and for this kind of thing you could just look at a few test runs and verify that builds have happened successfully elsewhere to have confidence so you don't even need to wait for the whole thing if you're impatient. |
|
@rvagg ok, I will do it next time if you insist. I just always try to spare the CI, and save some time for other people :) |
indutny
added a commit
that referenced
this pull request
Oct 2, 2015
Do not rely on `OPENSSL_FIPS` in `node_crypto.cc` when building with shared FIPS-enabled OpenSSL library. Enable FIPS in core only when configured with `--openssl-fips`. Fix: #3077 PR-URL: #3153 Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not rely on
OPENSSL_FIPSinnode_crypto.ccwhen building withshared FIPS-enabled OpenSSL library. Enable FIPS in core only when
configured with
--openssl-fips.Fix: #3077
cc @nodejs/crypto