Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test-dns-promises-lookupService #31640

Merged
merged 1 commit into from
Feb 7, 2020
Merged

test: add test-dns-promises-lookupService #31640

merged 1 commit into from
Feb 7, 2020

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 5, 2020

This adds covereage for the onlookupservice() callback in
lib/internal/dns/promises.js. Because of stubbing in other tests, it is
not currently covered.

This test works on my local development machine with the network turned
off, so I'm putting it in parallel. If CI proves more challenging, it
can be moved to the internet directory instead.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Feb 5, 2020
test/parallel/test-dns-promises-lookupService.js Outdated Show resolved Hide resolved
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with @cjihrig's suggestion

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 6, 2020
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 6, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 7, 2020

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 7, 2020
This adds covereage for the onlookupservice() callback in
lib/internal/dns/promises.js. Because of stubbing in other tests, it is
not currently covered.

This test works on my local development machine with the network turned
off, so I'm putting it in parallel. If CI proves more challenging, it
can be moved to the internet directory instead.

PR-URL: nodejs#31640
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@Trott
Copy link
Member Author

Trott commented Feb 7, 2020

Landed in 1d369a2

@Trott Trott merged commit 1d369a2 into nodejs:master Feb 7, 2020
@Trott Trott deleted the hi-1 branch February 7, 2020 07:06
codebytere pushed a commit that referenced this pull request Feb 17, 2020
This adds covereage for the onlookupservice() callback in
lib/internal/dns/promises.js. Because of stubbing in other tests, it is
not currently covered.

This test works on my local development machine with the network turned
off, so I'm putting it in parallel. If CI proves more challenging, it
can be moved to the internet directory instead.

PR-URL: #31640
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@codebytere codebytere mentioned this pull request Feb 17, 2020
codebytere pushed a commit that referenced this pull request Mar 15, 2020
This adds covereage for the onlookupservice() callback in
lib/internal/dns/promises.js. Because of stubbing in other tests, it is
not currently covered.

This test works on my local development machine with the network turned
off, so I'm putting it in parallel. If CI proves more challenging, it
can be moved to the internet directory instead.

PR-URL: #31640
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
This adds covereage for the onlookupservice() callback in
lib/internal/dns/promises.js. Because of stubbing in other tests, it is
not currently covered.

This test works on my local development machine with the network turned
off, so I'm putting it in parallel. If CI proves more challenging, it
can be moved to the internet directory instead.

PR-URL: #31640
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
@codebytere codebytere mentioned this pull request Mar 17, 2020
codebytere pushed a commit that referenced this pull request Mar 30, 2020
This adds covereage for the onlookupservice() callback in
lib/internal/dns/promises.js. Because of stubbing in other tests, it is
not currently covered.

This test works on my local development machine with the network turned
off, so I'm putting it in parallel. If CI proves more challenging, it
can be moved to the internet directory instead.

PR-URL: #31640
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants